Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable list rehydrating as a map, after upgrading to react-native 0.44.0 #13746

Closed
cbjs opened this issue May 3, 2017 · 2 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@cbjs
Copy link

cbjs commented May 3, 2017

Description

use redux / immutable for state.
redux-persist / redux-persist-transform-immutable for state persistence.

Every is good with react-native 0.43.4.
Immutable list rehydrating as a map, after upgrading to react-native 0.44.0

1

Reproduction Steps and Sample Code

import { persistStore, autoRehydrate } from 'redux-persist';
import immutableTransform from 'redux-persist-transform-immutable';

const configureStore = () => {
  const store = createStore(
    reducer,
    composeEnhancers( applyMiddleware(...middlewares), autoRehydrate() )
  );

  return store;
}
const store = configureStore();

persistStore(store, {
      storage: AsyncStorage,
      transforms: [immutableTransform()]
});

Solution

No workaround.
May this issue is related to packager updates in 0.44.0
related issues: rt2zz/redux-persist-transform-immutable#21
glenjamin/transit-immutable-js#32

Additional Information

  • React Native version: [0.44.0]
  • Platform: [Android]
  • Development Operating System: [Linux]
  • Dev tools: [android-23]
@brunolemos
Copy link
Contributor

brunolemos commented May 29, 2017

Hi @cbjs,

Problem

This issue was caused by multiple versions os immutable being installed, like pointed out on this issue: glenjamin/transit-immutable-js#32

Solution

Upgrade react-native to 0.45, as immutable dependency has been removed in this commit.

Run: npm i --save react-native@0.45.0-rc.2 react@16.0.0-alpha.12

Alternative solution

Ensure you only have 1 version of immutable installed. Change your immutable version to the same as react native is using (npm i --save immutable@3.7.6). Check for other packages requiring a specific version of immutable as well. Make a PR to them removing it or moving to peerDependencies if necessary. (if you use npm5 or yarn, you can check the lock file to see all immutable versions and who required them)

Feel free to close this issue if it works for you.
Thanks!

brunolemos added a commit to devhubapp/devhub that referenced this issue May 29, 2017
@hramos hramos added the Icebox label Jul 31, 2017
@hramos
Copy link
Contributor

hramos commented Jul 31, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Jul 31, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants