-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.45.1] Android release build failed #14548
Comments
I have tried all methods but all does not work |
+1 same issue |
Workaround - delete the |
I solve the problem by - delete the third-party folder generated in node_modules/react-native/ thanks @ben-snaize |
This worked for me: to delete the broken test-driver-link as follows
|
Thanks @itinance. This fixed my problem, was going to delete the folder if this didn't work, however the unlink fixed my Command Line build. Strangely however, if I built using Android Studio, I didn't run into this issue. |
Summary: After execution of `scripts/ios-install-third-party.sh` a symlink is created : `<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver` that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver` This can be executed indirectly by `react-native run-ios`. This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice. Once the `test-driver` symlink is created android app release is failing, for : `./gradlew assembleRelease` the `:app:bundleReleaseJsAndAssets` returns : ``` FAILURE: Build failed with an exception. * What went wrong: Could not list contents of '<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link. ``` Related issues: #14417 #14464 #14548 1. Create new project with `react-native init <YOUR-APP>` 2. cd `<YOUR-APP>/` 3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed. 4. cd `android/` 5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists) IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released. The proper cleanup of files generated by autotools was already applied : google/glog#188 Please let me know if I should provide more details : javache, mhorowitz, hramos Closes #14638 Differential Revision: D5292362 Pulled By: javache fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e
Summary: I encountered an issue when building with fastlane gym / xcodebuild where glog would not build because of missing config.h header file. I tracked it down to the ios-configure-glog.sh script that ended up error-ing because of missing valid c compiler. I guess it didn't enter the if to set c compiler env in xcodebuild and that env doesn't have proper values set like it does in xcode so just removing this check fixed it. Also tested that it still works properly in xcode. Closes #14267 Differential Revision: D5285691 Pulled By: javache fbshipit-source-id: df5315926c2d2d78806618df3d9c9bbbb974d1ea
Please see 5c53f89#commitcomment-23107918 |
This is fixed in master branch. Guess we need to wait for 0.47.0 |
Summary: After execution of `scripts/ios-install-third-party.sh` a symlink is created : `<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver` that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver` This can be executed indirectly by `react-native run-ios`. This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice. Once the `test-driver` symlink is created android app release is failing, for : `./gradlew assembleRelease` the `:app:bundleReleaseJsAndAssets` returns : ``` FAILURE: Build failed with an exception. * What went wrong: Could not list contents of '<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link. ``` Related issues: #14417 #14464 #14548 1. Create new project with `react-native init <YOUR-APP>` 2. cd `<YOUR-APP>/` 3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed. 4. cd `android/` 5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists) IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released. The proper cleanup of files generated by autotools was already applied : google/glog#188 Please let me know if I should provide more details : javache, mhorowitz, hramos Closes #14638 Differential Revision: D5292362 Pulled By: javache fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Not particulary fixed. Had to do a few workarounds: |
just like #14417
The text was updated successfully, but these errors were encountered: