Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.46] Commits to cherry-pick #14713

Closed
hramos opened this issue Jun 23, 2017 · 15 comments
Closed

[0.46] Commits to cherry-pick #14713

hramos opened this issue Jun 23, 2017 · 15 comments
Assignees
@hramos
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hramos
Copy link
Contributor

hramos commented Jun 23, 2017 •
edited
Loading

Fix: use prop-types with React 16

react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

The issue has been fixed in master. I don't think the fix made the 0.46-RC cut, so we'll also need to cherry-pick them into v0.46.0-rc.3.

Fix dev reloading on Android
@hramos hramos changed the title [v0.46.0-rc.3] Commits to cherry-pick and use prop-types with React 16 instead [0.46.0-rc.3] Commits to cherry-pick and use prop-types with React 16 instead Jun 23, 2017
This was referenced Jun 23, 2017
Closed
Closed
@mojodna
Copy link
Contributor

mojodna commented Jun 24, 2017

Commits to cherry-pick:

@hramos hramos self-assigned this Jun 25, 2017
@AndrewJack
Copy link
Contributor

c639a1f - fix dev reloading - related to #14533

@hramos
Copy link
Contributor Author

hramos commented Jun 28, 2017

@AndrewJack Is c639a1f related to the prop-types issue?

@AndrewJack
Copy link
Contributor

@hramos No it fixes Android DEV reloading and an issue with code push. It was fixed just after 0.46 cut.

@hramos hramos changed the title [0.46.0-rc.3] Commits to cherry-pick and use prop-types with React 16 instead [0.46.0-rc.3] Commits to cherry-pick Jun 29, 2017
@hramos
Copy link
Contributor Author

hramos commented Jun 29, 2017

Gotcha, it doesn't look like this is in the 0.46 RC as you mentioned, cherry picking it into 0.46 should help us prevent more issues getting opened about it. I updated this issue to cover all commits that we want to be cherry picked into 0.46

cc @grabbou to be aware, I am planning on cherry picking these once I get #14729 merged.

@grabbou grabbou mentioned this issue Jul 4, 2017
Closed
@grabbou
Copy link
Contributor

grabbou commented Jul 4, 2017

4fd427e to be cherry-picked from another issue

@grabbou grabbou changed the title [0.46.0-rc.3] Commits to cherry-pick [0.46] Commits to cherry-pick Jul 4, 2017
@grabbou
Copy link
Contributor

grabbou commented Jul 4, 2017

All commits were cherry-picked. Going to close this issue and we will land #14729 separately.

@grabbou grabbou closed this as completed Jul 4, 2017
@grabbou
Copy link
Contributor

grabbou commented Jul 4, 2017 via email

@gre
Copy link
Contributor

gre commented Jul 6, 2017

I wish ee42cd0 was picked in 0.46, sounds safe to add, is it still time for a patch?
thanks

hramos referenced this issue Jul 14, 2017
@yungsters @gre
RN: Expose unstable_batchedUpdates on react-native
ee42cd0 
Reviewed By: spicyj

Differential Revision: D5284484

fbshipit-source-id: bdc0a1c3babfa1a5c3343f084bdd5d4ff4f2d46a
@hramos
Copy link
Contributor Author

hramos commented Jul 14, 2017 •
edited
Loading

Re-opening for 0.46.3 release.

v0.46.3

@hramos hramos reopened this Jul 14, 2017
hramos referenced this issue Jul 14, 2017
@janicduplessis @facebook-github-bot
Fix configure glog script when building from xcodebuild
5c53f89 
Summary:
I encountered an issue when building with fastlane gym / xcodebuild where glog would not build because of missing config.h header file. I tracked it down to the ios-configure-glog.sh script that ended up error-ing because of missing valid c compiler. I guess it didn't enter the if to set c compiler env in xcodebuild and that env doesn't have proper values set like it does in xcode so just removing this check fixed it. Also tested that it still works properly in xcode.
Closes #14267

Differential Revision: D5285691

Pulled By: javache

fbshipit-source-id: df5315926c2d2d78806618df3d9c9bbbb974d1ea
@hramos
Copy link
Contributor Author

hramos commented Jul 14, 2017

v0.46.3 has been cut and will be released once https://circleci.com/gh/facebook/react-native/19569 finishes.

@ujwal-setlur
Copy link

Critical iOS fix is needed:

5c53f89

@ujwal-setlur
Copy link

Looks like it got included. Thanks!

@ujwal-setlur
Copy link

ujwal-setlur commented Jul 14, 2017 •
edited
Loading

If we have a 0.46.4, please include 7d1981e to fix android build issue :)

@grabbou
Copy link
Contributor

grabbou commented Jul 17, 2017

Releasing and closing this issue, thanks!

@grabbou grabbou closed this as completed Jul 17, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 17, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hramos hramos

Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mojodna @hramos @gre @AndrewJack @grabbou @ujwal-setlur @react-native-bot