Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatList refresh bug #14761

Closed
zzetao opened this issue Jun 28, 2017 · 13 comments
Closed

FlatList refresh bug #14761

zzetao opened this issue Jun 28, 2017 · 13 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@zzetao
Copy link

zzetao commented Jun 28, 2017

Is this a bug report?

Yes.

Have you read the Bugs section of the Contributing to React Native Guide?

Yes.

Environment

react-native -v: 0.43.4
node -v: 7.7.4
npm -v: 4.1.2
yarn --version: 0.22.0

Then, specify:

Target Platform (e.g. iOS, Android): iOS
Development Operating System: macOS Sierra
Build tools : Xcode

Description

The first press is invalid after refreshing, See the demo for details.

Reproducible Demo

https://snack.expo.io/Hyd4CAlEb

@hramos
Copy link
Contributor

hramos commented Jun 28, 2017

Can you elaborate a bit more? Please explain the list of steps to reproduce, what was expected, and what happened instead.

@andrewda
Copy link

@hramos I believe the issue is that after refreshing the FlatList, the TouchableHighlight does not respond to the first press. The user has to press the TouchableHighlight twice in order to get the Alert to appear.

@michaelspeed
Copy link

i can confirm this on iOS but android is working as expected

@eladgel
Copy link

eladgel commented Jul 31, 2017

react-native -v: 0.46.4
node -v: 6.9.2
npm -v: 3.10.9
yarn --version: 0.27.5

Then, specify:

Target Platform (e.g. iOS, Android): iOS
Development Operating System: macOS Sierra
Build tools : Xcode

Happens also with ScrollView and ListView
notice that the touchable element becomes untappable when you scroll and reach the end of the scrolling component(ListView/ScrollView/FlatList)

23c2a6c
is supposed to fix this, waiting for RN 0.47 then :(

---update 8/1/2017
tested 0.47 rc 5
the following code is implemented in both

ReactNativeStack-dev &  ReactNativeStack-prod

function accumulateDispatches(inst, ignoredDirection, event) {
    if (inst && event && event.dispatchConfig.registrationName) {
        var registrationName = event.dispatchConfig.registrationName, listener = getListener(inst, registrationName);
        listener && (event._dispatchListeners = accumulateInto_1(event._dispatchListeners, listener),
        event._dispatchInstances = accumulateInto_1(event._dispatchInstances, inst));
    }
}

This does not fix the problem

@narodejesus
Copy link

narodejesus commented Aug 6, 2017

what @andrewda said is what is exactly happening to our app when using the RefreshControl component
ListView or FlatList has the same issue in our end (only in IOS) working well in android

#14761 (comment)

@pull-bot
Copy link

pull-bot commented Oct 9, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Oct 9, 2017
@hramos hramos closed this as completed Oct 9, 2017
@Furqankhanzada
Copy link

@zzetao any solution ? i am also facing this issue.

@eladgel
Copy link

eladgel commented Oct 24, 2017

react-native -v: 0.49.3

same thing :(

@eladgel
Copy link

eladgel commented Nov 15, 2017

I can't repro on iphoneX, every other iphone, still happening

@narodejesus
Copy link

i encountered this few months ago .. but now i am using 0.47.2 @eladgel it doesn't seem a problem anymore .. perhaps it was fixed

@fallenner
Copy link

it's still happening I am using 0.52 android

@AnotherEye
Copy link

it's still happening using reactnative -v 0.54.2 iOS

@jemoav
Copy link

jemoav commented Oct 4, 2018

In #20011 there is an useful solution

@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests