Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.47] Commits to cherry-pick into stable release #14840

Closed
grabbou opened this issue Jul 5, 2017 · 14 comments
Closed

[0.47] Commits to cherry-pick into stable release #14840

grabbou opened this issue Jul 5, 2017 · 14 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@grabbou
Copy link
Contributor

grabbou commented Jul 5, 2017

No description provided.

@mhorowitz
Copy link
Contributor

mhorowitz commented Jul 7, 2017

Two commits for the 0.47 branch to get CocoaPods working right with the new bridge:

1ef21ec
26f01fa

Thanks! cc @javache

@javache
Copy link
Member

javache commented Jul 7, 2017

This one too then, if we're aiming for a fully working Podspec in 0.47: 6c2beaf

@ide
Copy link
Contributor

ide commented Jul 7, 2017

I went ahead and cherry-picked those three commits (1ef21ec, 26f01fa, 6c2beaf) and pushed 0.47.0-rc.1. Think it will be good if people can start testing the Podspec (and therefore RN 0.47 in general as well) early.

@grabbou
Copy link
Contributor Author

grabbou commented Jul 7, 2017 via email

@javache
Copy link
Member

javache commented Jul 12, 2017

Please pick e43c061 which fixes another Podspec issue

@ide
Copy link
Contributor

ide commented Jul 13, 2017

Picked e43c061 and sent 0.47.0-rc.3 to CI. (9afb71f is part of 0.47.0-rc.2).

@javache
Copy link
Member

javache commented Jul 19, 2017

Documentation fix: 6e68f2d

@robhogan
Copy link
Contributor

Could we pull 7e29b1f in? Binary websocket comms are broken on Android (since 0.46) otherwise. (eg robhogan/react-native-paho-mqtt#5).

@ide
Copy link
Contributor

ide commented Jul 26, 2017

Cherry-picked 7e29b1f (fixes binary WebSocket messages) and 113e046 (exposes option to turn off .babelrc lookup algorithm instead of having to find and remove node_modules/**/.babelrc). The podspec documentation fix was already cherry-picked. 0.47.0-rc.5 is now in CI.

@hramos
Copy link
Contributor

hramos commented Jul 31, 2017

@brentvatne asked for b8fafb4 to be cherry-picked into 0.47

@forki
Copy link
Contributor

forki commented Aug 1, 2017

please pick 63c2ab3 so that android toolbar works properly.

@grabbou
Copy link
Contributor Author

grabbou commented Aug 1, 2017

I am wrapping up changelog for this release and cherry-picking those commits. Stable should be on its way pretty soon.

@grabbou grabbou closed this as completed Aug 1, 2017
@hramos
Copy link
Contributor

hramos commented Aug 1, 2017

If possible, cherry pick 471c9da which will fix a CSS issue in the site. This one doesn't need to go out to npm, so it's fine to cherry pick it after the cut.

@eliperkins
Copy link
Contributor

I'd like to nominate 603cc48ceba001827d10231d51b4031c7768eef8, as described in this comment: 603cc48#commitcomment-23539206

I think this needs to get cherry picked into 0.47.0-stable to fix issues like #15326. Otherwise, multiline autoexpanding TextInputs will always return the same height for their content.

(sorry for the run-around on #15318!)

@facebook facebook locked as resolved and limited conversation to collaborators Aug 1, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

9 participants