Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundling is not working on release #17811

Closed
fatimaranile opened this issue Feb 1, 2018 · 2 comments
Closed

Unbundling is not working on release #17811

fatimaranile opened this issue Feb 1, 2018 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@fatimaranile
Copy link

fatimaranile commented Feb 1, 2018

Is this a bug report?

No

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS Sierra 10.13.1
Node: 6.11.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.0 Build version 9A235
Android Studio: 3.0.1 AI-171.4443003

Packages: (wanted => installed)
react-native: 0.51.0 => 0.51.0
react: 16.0.0 => 16.0.0

Target Platform: iOS (9)

Steps to Reproduce

I tried implementing the unbundling and inline requires to my project. It works on simulation but when I release the project on iOs or create an apk for android errors occurred.

Errors Occurred

TransformError: /Users/<user_name>/<folderPath>/<projectfoldername>/<project_name>/clients/mobile/node_modules/react-native/Libraries/Components/AccessibilityInfo/AccessibilityInfo.ios.js: /Users/<user_name>/<folderPath>/projectfoldername/<project_name>/clients/mobile/node_modules/react-native/Libraries/Components/AccessibilityInfo/AccessibilityInfo.ios.js: NodePath has been removed so is read-only. (This is an error on an internal node. Probably an internal error)

error: File /Users/<user_name>/Library/Developer/Xcode/DerivedData/<project_name>-fggebbxvaywbawbbcoypijwnkwjm/Build/Intermediates.noindex/ArchiveIntermediates/therion_mobile/BuildProductsPath/Release-iphoneos/<project_name>.app/main.jsbundle does not exist.

Then I noticed that the component AccessibilityInfo is in the waiting module but the instruction from the link I pasted below said that only the loaded modules will be put on the moduleNames.

I tried to put the modules that are waiting to the moduleNames.js it resulted to a success in release but the speed of the mobile app did not improve. This occurred on both iOs and Android platforms.

(Write your steps here:)

  1. I followed all the steps from this link https://facebook.github.io/react-native/docs/performance.html#unbundling-inline-requires
  2. yarn start
  3. In xcode Clean --> Build --> Archive Project

Expected Behavior

The startup speed should improve.

Actual Behavior

The startup speed is still the same with disabled unbundling.

Can anyone tell me what I'm missing or if there is something I need to know to successfully implement unbundling and inline requires on my react native project? Thank you

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 24, 2018
@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@facebook facebook locked as resolved and limited conversation to collaborators Feb 24, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants