Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native link works incorrect #18333

Closed
itoys opened this issue Mar 12, 2018 · 0 comments
Closed

react-native link works incorrect #18333

itoys opened this issue Mar 12, 2018 · 0 comments
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.

Comments

@itoys
Copy link

itoys commented Mar 12, 2018 •
edited
Loading

After merging #17961 react-native link command works wrong.

Before, params field was used only for android and waiting for user response, now it uses for all platforms without waiting user input.

Seem like that main reason it's that you doesn't work with promises and just use Object.keys().forEach(link)

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.1
Yarn: 0.15.1
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.1 => 0.54.1

Expected Behavior

  1. Waiting user interaction while params polling
  2. If you would like to add params fo all platforms, please add platform field for filter purpose

Actual Behavior

I've got duplicate questions in terminal, "postinstall" script runs before user set up params

Steps to Reproduce

$ react-native init AwesomeProject
$ cd AwesomeProject
$ npm i react-native-code-push --save
$ react-native link react-native-code-push

So we'll get mess in terminal
@itoys itoys mentioned this issue Mar 13, 2018
Closed
@hramos hramos added CLI 💻 Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. labels Mar 13, 2018
@react-native-bot react-native-bot added the Platform: macOS Building on macOS. label Mar 20, 2018
grabbou pushed a commit that referenced this issue Mar 22, 2018
@grabbou
While linking plugin ask for params only once
863a49f 
Summary:
Resolve #18333

CLI should ask users for params only once and waiting for response while linking plugin

Ran the `link` commands for iOS and Android and confirmed that params requested only once.

[CLI][FEATURE][local-cli/link/link.js] - Requesting link params only once for all platforms
Closes #18349

Differential Revision: D7342181

Pulled By: hramos

fbshipit-source-id: a10f0f7f2170f067d78b30e5a5221634b77da577
@hramos hramos removed the Platform: macOS Building on macOS. label Mar 29, 2018
macdoum1 pushed a commit to macdoum1/react-native that referenced this issue Jun 28, 2018
@macdoum1
While linking plugin ask for params only once
8895493 
Summary:
Resolve facebook#18333

CLI should ask users for params only once and waiting for response while linking plugin

Ran the `link` commands for iOS and Android and confirmed that params requested only once.

[CLI][FEATURE][local-cli/link/link.js] - Requesting link params only once for all platforms
Closes facebook#18349

Differential Revision: D7342181

Pulled By: hramos

fbshipit-source-id: a10f0f7f2170f067d78b30e5a5221634b77da577
@facebook facebook locked as resolved and limited conversation to collaborators Mar 20, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hramos @itoys @react-native-bot