Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about Animated.subtract? #18451

Closed
dgreensp opened this issue Mar 19, 2018 · 5 comments
Closed

How about Animated.subtract? #18451

dgreensp opened this issue Mar 19, 2018 · 5 comments
Labels
API: Animated Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion. Type: Enhancement A new feature or enhancement of an existing feature.

Comments

@dgreensp
Copy link

I'm finding myself typing Animated.add(x, Animated.multiply(-1, y)) a lot.

Would you take a PR that adds an Animated.subtract?
@hramos hramos added Type: Discussion Long running discussion. API: Animated labels Mar 19, 2018
@hramos
Copy link
Contributor

hramos commented Mar 19, 2018

cc @janicduplessis

@janicduplessis
Copy link
Contributor

janicduplessis commented Mar 20, 2018 •
edited
Loading

Sure, we have Animated.divide so I guess substract does make sense too. If you want to make a PR I can review it, it should be relatively simple if you start from the add implementation.

@janicduplessis janicduplessis added Help Wanted :octocat: Issues ideal for external contributors. 🌟Feature Request and removed Type: Discussion Long running discussion. labels Mar 20, 2018
@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue may be incomplete. Are all the fields required by the Issue Template filled out?

If you believe your issue contains all the relevant information, let us know in order to have a maintainer remove the No Template label. Thank you for your contributions.

How to Contribute • What to Expect from Maintainers

@hramos hramos added the Type: Discussion Long running discussion. label Mar 20, 2018
@avendiart
Copy link
Contributor

Hey, @dgreensp are you working on it? Or is it something I could take on?

@dgreensp
Copy link
Author

@avendiart Go for it!

@avendiart avendiart mentioned this issue Mar 30, 2018
Closed
campsafari pushed a commit to exozet/react-native that referenced this issue Apr 11, 2018
@avendiart @campsafari
Add an implementation of Animated.subtract
1957f80 
Summary:
Fixes facebook#18451

I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:

<img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
<img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

facebook/react-native-website#276

[GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
Closes facebook#18630

Differential Revision: D7462867

Pulled By: hramos

fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this issue Apr 11, 2018
@avendiart @LukeDurrant
Add an implementation of Animated.subtract
7fff4b7 
Summary:
Fixes facebook#18451

I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:

<img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
<img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

facebook/react-native-website#276

[GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
Closes facebook#18630

Differential Revision: D7462867

Pulled By: hramos

fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this issue Apr 11, 2018
@avendiart @LukeDurrant
Add an implementation of Animated.subtract
75d4894 
Summary:
Fixes facebook#18451

I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:

<img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
<img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

facebook/react-native-website#276

[GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
Closes facebook#18630

Differential Revision: D7462867

Pulled By: hramos

fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
bunnyc1986 pushed a commit to bunnyc1986/react-native that referenced this issue May 11, 2018
@avendiart @bunnyc1986
Add an implementation of Animated.subtract
b158190 
Summary:
Fixes facebook#18451

I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:

<img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
<img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

facebook/react-native-website#276

[GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
Closes facebook#18630

Differential Revision: D7462867

Pulled By: hramos

fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
macdoum1 pushed a commit to macdoum1/react-native that referenced this issue Jun 28, 2018
@avendiart @macdoum1
Add an implementation of Animated.subtract
e6f7faf 
Summary:
Fixes facebook#18451

I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:

<img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
<img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

facebook/react-native-website#276

[GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
Closes facebook#18630

Differential Revision: D7462867

Pulled By: hramos

fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
@hramos hramos added the Type: Enhancement A new feature or enhancement of an existing feature. label Mar 14, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 31, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API: Animated Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dgreensp @hramos @avendiart @janicduplessis @react-native-bot