Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-standard behavior of Promise.prototype.finally #19490

Closed
3 tasks done
leeyeh opened this issue May 29, 2018 · 4 comments
Closed
3 tasks done

Non-standard behavior of Promise.prototype.finally #19490

leeyeh opened this issue May 29, 2018 · 4 comments
Labels
Bug JavaScript 📮Known Issues This indicates an issue that refers to a bug or limitation of RN that is not currently being handled Resolution: Locked This issue was locked by the bot.

Comments

@leeyeh
Copy link
Contributor

leeyeh commented May 29, 2018

Environment

Environment:
  OS: macOS High Sierra 10.13.4
  Node: 9.11.1
  Yarn: 1.7.0
  npm: 6.1.0
  Watchman: 4.9.0
  Xcode: Xcode 9.3.1 Build version 9E501
  Android Studio: 3.1 AI-173.4670197

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: ~0.55.2 => 0.55.4

Steps to Reproduce

https://snack.expo.io/r1wCcj5JQ

Expected Behavior

console: 42

Actual Behavior

console: undefined

I did some digging around, finding that the polyfilled Promise imported from fbjs is not implemented right:

https://github.com/facebook/fbjs/blob/v0.8.16/src/__forks__/Promise.native.js#L18-L23

There is already an issue about this years ago: facebook/fbjs#132

Another related issue: #17972
@leeyeh leeyeh mentioned this issue May 29, 2018
Closed
leeyeh added a commit to leeyeh/js-realtime-sdk that referenced this issue May 31, 2018
@leeyeh
fix: do not use Promise#finally
f2dacfc 
until facebook/react-native#19490 is fixed.
@liuqiang1357 liuqiang1357 mentioned this issue Jun 7, 2018
Open
@hramos hramos removed the Bug Report label Feb 6, 2019
@hramos hramos added 📮Known Issues This indicates an issue that refers to a bug or limitation of RN that is not currently being handled and removed Core Team labels Mar 8, 2019
@cpojer cpojer mentioned this issue Mar 19, 2019
Closed
@cpojer
Copy link
Contributor

cpojer commented Mar 28, 2019

I'm currently landing a fix for this.

@cpojer cpojer closed this as completed Mar 28, 2019
@jeremy303
Copy link

jeremy303 commented Apr 3, 2019 •
edited
Loading

@cpojer What is the appropriate issue to track to follow this fix? (And thanks for addressing the problem. :-)

@cpojer
Copy link
Contributor

cpojer commented Apr 3, 2019

There is no issue, this was already landed on master last week.

@gianpaj
Copy link

gianpaj commented Apr 5, 2019

For those looking for the commit like me:
d5ae59a

@RXminuS RXminuS mentioned this issue Oct 2, 2019
Closed
@facebook facebook locked as resolved and limited conversation to collaborators Mar 28, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug JavaScript 📮Known Issues This indicates an issue that refers to a bug or limitation of RN that is not currently being handled Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cpojer @hramos @leeyeh @gianpaj @jeremy303 @react-native-bot