Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeableFlatList bleeding pixel #21167

Closed
3 tasks done
Dimous opened this issue Sep 18, 2018 · 3 comments
Closed
3 tasks done

SwipeableFlatList bleeding pixel #21167

Dimous opened this issue Sep 18, 2018 · 3 comments
Labels
Bug Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Resolution: Locked This issue was locked by the bot.

Comments

@Dimous
Copy link

Dimous commented Sep 18, 2018

Environment

React Native Environment Info:
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz
Memory: 589.87 MB / 5.45 GB
Binaries:
Yarn: 1.9.4 - C:\Users\kasim\AppData\Roaming\npm\yarn.CMD
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.1.0.0 AI-173.4907809

Description

When you swipe an item, you can see "bleeding" on the right of it. It is noticable on a physical device. I guess, "x" property should be rounded.

Please, wait till gif below is loaded

swipablelistview

@hramos
Copy link
Contributor

hramos commented Sep 18, 2018

Thanks for the visual demonstration. Can you include a code sample that we can use to repro this?

@Dimous
Copy link
Author

Dimous commented Sep 19, 2018

https://snack.expo.io/Bk54hV1tQ

You probably won't see it on emulator or a hdpi-device. I use Samsung Galaxy Note II.

On the screenshot below there is a barely noticeable bleeding. Don't let the blurring of icons mislead you. The edges of swipable items should be crisp (and they are, when the horizontal position has an integer value).
bleeding
Image is clickable, btw.

@hramos hramos added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. 🔶Components and removed 🔶Components labels Sep 20, 2018
@Dimous Dimous changed the title SwipeableListView bleeding pixel SwipeableFlatList bleeding pixel Oct 26, 2018
@hramos hramos removed the Bug Report label Feb 6, 2019
@kelset
Copy link
Contributor

kelset commented Mar 19, 2019

Hello there 👋 this issue has been reported for an old version of React Native. Ideally we'd like everyone to be using 0.59 (see the awesome changes it brought) but we know updating can be a pain.

Also, both ListView and SwipeableListView are going to be removed, and your repro uses that.

But please, if it's actually still an issue with 0.59 please comment below and we can reopen it. Even better, please send us a pull request with a fix 😊

@kelset kelset closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants