Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeableFlatList items now snapped to nearest pixels to prevent bleeding #21534

Closed
wants to merge 2 commits into from
Closed

Conversation

Dimous
Copy link

@Dimous Dimous commented Oct 6, 2018

Fixes #21167

Unfortunately, when position is animated, bleeding occurs but that's ok

Test Plan

  1. Add and configure SwipableListView
  2. Deploy on a non-hdpi-device
  3. Slowly swipe an item

Related PRs

N/A

Release Notes

[GENERAL] [ENHANCEMENT] [SwipableListView] - eleminates right-side pixel bleeding when item background color is not of the same color as list

Unfortunately, when position is animated, bleeding occurs but that's ok
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

@pull-bot
Copy link

pull-bot commented Oct 6, 2018

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

@Dimous
Copy link
Author

Dimous commented Oct 6, 2018

Because of

Configuration for rule "prettier/prettier" is invalid:
Value "fb" should be object.

when I ran eslint SwipeableRow.js I'm now catching errors by trial and error 😂

@Dimous Dimous changed the title Fixes #21167 SwipableListView items now snapped to nearest pixels to prevent bleeding Oct 6, 2018
@Dimous Dimous closed this Oct 26, 2018
@Dimous
Copy link
Author

Dimous commented Oct 26, 2018

I cannot reopen this PR because I removed my fork.

@Dimous Dimous changed the title SwipableListView items now snapped to nearest pixels to prevent bleeding SwipeableFlatList items now snapped to nearest pixels to prevent bleeding Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants