Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNTesterIntegrationTests: Fix testTimersTest failure #22695

Closed
hramos opened this issue Dec 18, 2018 · 0 comments
Closed

RNTesterIntegrationTests: Fix testTimersTest failure #22695

hramos opened this issue Dec 18, 2018 · 0 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.

Comments

@hramos
Copy link
Contributor

hramos commented Dec 18, 2018 •
edited
Loading

Help Wanted: Fix TimersTests

test_objc on Circle CI is red due to a failing integration test, TimersTest:

UI Test Activity: 
Assertion Failure: RCTTestRunner.m:233: failed: caught "NSInternalInconsistencyException", "RedBox errors: (
    "undefined is not an object (evaluating 'this.setTimeout')",
    "Unhandled JS Exception: undefined is not an object (evaluating 'this.setTimeout')"
)"

The test is defined in JavaScript at IntegrationTests/TimersTest.js, and is invoked by RNTesterIntegrationTests.

Steps to reproduce:

  1. Run yarn at the repository root.
  2. Open RNTester/RNTester.xcodeproj on Xcode 10.1.0.
  3. Build RNTester.
  4. Run tests (CMD+U) on an iPhone 6 simulator.
@hramos hramos added Platform: iOS iOS applications. Help Wanted :octocat: Issues ideal for external contributors. 🔩Test Infrastructure Test infrastructure and continuous integration. ❌CI Test Failure labels Dec 18, 2018
This was referenced Dec 19, 2018
Closed
Closed
facebook-github-bot pushed a commit that referenced this issue Dec 20, 2018
@hramos @facebook-github-bot
test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failin…
86d0611 
…g tests (#22720)

Summary:
The following tests are disabled in this PR:

- testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in #22695
- testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in #22697

I've added a comment regarding testWebSocketTest and how to ensure it passes locally.

This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Pull Request resolved: #22720

Differential Revision: D13532788

Pulled By: hramos

fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
grabbou pushed a commit that referenced this issue Dec 24, 2018
@hramos @grabbou
test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failin…
1df4713 
…g tests (#22720)

Summary:
The following tests are disabled in this PR:

- testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in #22695
- testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in #22697

I've added a comment regarding testWebSocketTest and how to ensure it passes locally.

This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Pull Request resolved: #22720

Differential Revision: D13532788

Pulled By: hramos

fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
@hramos hramos closed this as completed Jan 31, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
@hramos @grabbou
test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failin…
7659079 
…g tests (facebook#22720)

Summary:
The following tests are disabled in this PR:

- testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in facebook#22695
- testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in facebook#22697

I've added a comment regarding testWebSocketTest and how to ensure it passes locally.

This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Pull Request resolved: facebook#22720

Differential Revision: D13532788

Pulled By: hramos

fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
rozele pushed a commit to microsoft/react-native-windows that referenced this issue Jul 18, 2019
@hramos @facebook-github-bot
test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failin…
9287e48 
…g tests (#22720)

Summary:
The following tests are disabled in this PR:

- testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in facebook/react-native#22695
- testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in facebook/react-native#22697

I've added a comment regarding testWebSocketTest and how to ensure it passes locally.

This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Pull Request resolved: facebook/react-native#22720

Differential Revision: D13532788

Pulled By: hramos

fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
@facebook facebook locked as resolved and limited conversation to collaborators Jan 31, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hramos @react-native-bot