-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefreshControl in FlatList makes borderWidth not working #22752
Labels
Bug
Component: FlatList
Component: RefreshControl
Priority: Low
Resolution: Locked
This issue was locked by the bot.
Comments
I was able to repro this on 0.59. |
@TheSavior it seems that the bug is caused by one line of legacy code. Please, look at my PR. |
kelset
pushed a commit
that referenced
this issue
Jun 7, 2019
Summary: Fixes #22752 On line 1021 you are passing base style to props: `style: [baseStyle, this.props.style],` Explicitly passing base style to ScrollView just overrides this line and doesn't let developers to customise style of any inheritors of ScrollView (not only FlatList) with custom RefreshControl. So this line (1113) seems to be removed. ## Changelog [GENERAL] [Fixed] - fix of Android's bug that doesn't let override ScrollView's Style with custom RefreshControl. Pull Request resolved: #24411 Differential Revision: D15713061 Pulled By: cpojer fbshipit-source-id: 461259800f867af15e53e0743a5057ea4528ae69
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this issue
Mar 10, 2020
…ok#24411) Summary: Fixes facebook#22752 On line 1021 you are passing base style to props: `style: [baseStyle, this.props.style],` Explicitly passing base style to ScrollView just overrides this line and doesn't let developers to customise style of any inheritors of ScrollView (not only FlatList) with custom RefreshControl. So this line (1113) seems to be removed. ## Changelog [GENERAL] [Fixed] - fix of Android's bug that doesn't let override ScrollView's Style with custom RefreshControl. Pull Request resolved: facebook#24411 Differential Revision: D15713061 Pulled By: cpojer fbshipit-source-id: 461259800f867af15e53e0743a5057ea4528ae69
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bug
Component: FlatList
Component: RefreshControl
Priority: Low
Resolution: Locked
This issue was locked by the bot.
Environment
Description
Describe your issue in detail. Include screenshots if needed. If this is a regression, let us know.
Reproducible Demo
react-native init MyTestingProject
cd MyTestingProject
react-native run-android
<FlatList>
:refreshControl
to see the borders:The text was updated successfully, but these errors were encountered: