Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New App Screen #24760

Closed
5 tasks done
cpojer opened this issue May 8, 2019 · 14 comments
Closed
5 tasks done

New App Screen #24760

cpojer opened this issue May 8, 2019 · 14 comments
Labels
p: Facebook Partner: Facebook Partner Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. RN Team Type: Discussion Long running discussion. Type: Enhancement A new feature or enhancement of an existing feature.

Comments

@cpojer
Copy link
Contributor

cpojer commented May 8, 2019 •
edited
Loading

This is the list of remaining things to do before we can ship the new app screen (see react-native-community/discussions-and-proposals#122). The initial version of the code was landed via #24737:

cc @eliperkins @lucasbento would be awesome if you could help out! :)
@cpojer cpojer added the Bug label May 8, 2019
@react-native-bot
Copy link
Collaborator

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels May 8, 2019
@cpojer cpojer added p: Facebook Partner: Facebook Type: Enhancement A new feature or enhancement of an existing feature. and removed Resolution: Needs More Information labels May 8, 2019
@lucasbento
Copy link
Contributor

I would love to help on this, specially the opening links on the browser part.

Would this be targeting 0.61? I'm currently busy with some stuff for the CLI but I would probably be able to do some stuff for this next week.

@cpojer
Copy link
Contributor Author

cpojer commented May 8, 2019

Yep, 0.61. Ideally we'll wrap this work up by the end of the month.

@react-native-bot
Copy link
Collaborator

Can you run react-native info and edit your issue to include these results under the React Native version: section?

If you believe this information is irrelevant to the reported issue, you may write `[skip envinfo]` alongside an explanation in your Environment: section.

@cpojer cpojer mentioned this issue May 8, 2019
Closed
@eliperkins eliperkins mentioned this issue May 9, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue May 9, 2019
@eliperkins @facebook-github-bot
Polish new app screen component styling (#24783)
233fddb 
Summary:
Related to #24760 and #24737

This simplifies some styling within the components used for the New App Screen to help advocate for best practices when styling with CSS-like styles in React Native, as well as using React Native's own unique components.

There's a bit more detail in each commit. Let me know if you'd like me to pull that info out into the PR description here!

[General] [Changed] - Polished up new app screen component styling
Pull Request resolved: #24783

Differential Revision: D15284851

Pulled By: cpojer

fbshipit-source-id: 954db00d39fc0082bbd4dc96afa7d38dfb7f67d5
@cpojer
Copy link
Contributor Author

cpojer commented May 10, 2019

@eliperkins do you wanna take care of adding a follow on twitter link + putting it into the actual template? :)

@eliperkins
Copy link
Contributor

@cpojer sure thing. I'll tackle the moving to the template part now that the polish PR has landed.

As for the Twitter link, do you expect that to be a link to https://twitter.com/reactnative or is there another, more follow-specific link that we can put in there?

@cpojer
Copy link
Contributor Author

cpojer commented May 10, 2019

Yep, that links is good :)

This was referenced May 10, 2019
Closed
Closed
@eliperkins
Copy link
Contributor

#24805 and #24806 are up now!

I think there's still some work to do to rearrange components and tuck some complexity away before I'd call this template ready to ship, so I'd love some feedback.

@lucasbento
Copy link
Contributor

@ericlewis opened a PR for the open in browser functionality on CLI: react-native-community/cli#383.

@cpojer
Copy link
Contributor Author

cpojer commented May 13, 2019

Alright, so the main remaining thing is to hook up @ericlewis's new feature with the buttons in the new app screen. @lucasbento could you make that happen? Ideally if you could add a video in the test plan to show that it works that would be best :D

facebook-github-bot pushed a commit that referenced this issue May 13, 2019
@eliperkins @facebook-github-bot
Add Follow us on Twitter link to new app screen (#24806)
0245fd7 
Summary:
This adds in a link to the reactnative Twitter handle so our users can follow along with the latest and greatest of React Native!

Related to #24760

[General] [Added] - Added link to reactnative Twitter handle to Learn More section
Pull Request resolved: #24806

Differential Revision: D15316771

Pulled By: cpojer

fbshipit-source-id: cd45f005cfbcbd277fadb48be8943d60f4386767
@lucasbento lucasbento mentioned this issue May 14, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue May 14, 2019
@eliperkins @facebook-github-bot
Replace new app template with new app screen (#24805)
fe88e9e 
Summary:
This replaces the "new app screen" in the template with the new design from react-native-community/discussions-and-proposals#122

This uses components that are shipped as part of the `react-native` module, but not necessarily as proper components exported by the main `react-native` module. To use these, we use absolute imports to those components.

Related to #24760

[General] [Changed] - Updated new app template design 💖
Pull Request resolved: #24805

Differential Revision: D15334459

Pulled By: cpojer

fbshipit-source-id: d0b67d08f936eeabd9e93d4e0ff78302b4d6429f
facebook-github-bot pushed a commit that referenced this issue May 14, 2019
@lucasbento @facebook-github-bot
Open links from new app screen in computer's browser (#24843)
aa926e3 
Summary:
This PR is related to #24760 and adds the `openURLInBrowser` functionality introduced on react-native-community/cli#383.

[General] [Changed] - Open links from new app in computer's browser.
Pull Request resolved: #24843

Reviewed By: rickhanlonii

Differential Revision: D15334011

Pulled By: cpojer

fbshipit-source-id: 947ad1b113923989cf706e60851e02a87e1099e8
@cpojer
Copy link
Contributor Author

cpojer commented May 14, 2019

Thank you everyone for making this happen. This was a super awesome collaboration between so many people. @rickhanlonii and I made a brief video to show off the new screen: https://www.youtube.com/watch?v=ImlAqMZxveg&feature=youtu.be

@cpojer cpojer closed this as completed May 14, 2019
@gamingumar
Copy link

@cpojer Can we upgrade typescript template to support this? Typescript template is still using old screen..

@orta
Copy link
Contributor

orta commented Jul 4, 2019

Give it a shot at updating yourself @gamingumar - I think it's this one: https://github.com/react-native-community/react-native-template-typescript

@gamingumar
Copy link

Hi @orta Sure, I can create a PR for it, just need an input where should that typescript template live? As this one lives in react-native/Libraries

@facebook facebook locked as resolved and limited conversation to collaborators May 14, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: Facebook Partner: Facebook Partner Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. RN Team Type: Discussion Long running discussion. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@cpojer @orta @hramos @eliperkins @gamingumar @lucasbento @facebook-github-bot @react-native-bot