Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebSocket & JS] Use a websocket module that doesn't require native modules #277

Closed
amasad opened this issue Mar 26, 2015 · 8 comments
Closed
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@amasad
Copy link
Contributor

amasad commented Mar 26, 2015

ws package requires native modules. And it's a bit fragile while installing. Let's find a pure JS one

@naartjie
Copy link

naartjie commented Apr 6, 2015

@amasad have you managed to get ws working at all? I would like to use it for Firebase.

Also, have you seen these: #579 #619 and this project: https://github.com/tptee/RCTWebSocket

@amasad
Copy link
Contributor Author

amasad commented Apr 7, 2015

This is about the server use of WS (for debugging). When you npm install it installs native extensions which slows down the install.

@naartjie
Copy link

naartjie commented Apr 7, 2015

ah, gotcha, doh. thanks ;-)

On Tue, Apr 7, 2015 at 8:23 PM, Amjad Masad notifications@github.com
wrote:

This is about the server use of WS (for debugging). When you npm install
it installs native extensions which slows down the install.


Reply to this email directly or view it on GitHub
#277 (comment)
.

@vkurchatkin
Copy link
Contributor

ws package requires native modules

It doesn't, actually. Native deps are optional

@amasad
Copy link
Contributor Author

amasad commented Apr 8, 2015

@vkurchatkin great, how do we disable them? i.e. they don't install

@vkurchatkin
Copy link
Contributor

I don't think we can. Being optional dependency means that if npm fails to install it, it still proceeds.

@brentvatne
Copy link
Collaborator

@amasad - Would this be a websocket polyfill that relies on polling? Is this still an issue that is worth following up on? It seems like the built in WebSocket Native Module works well 😄

@brentvatne brentvatne changed the title Use a websocket module that doesn't require native modules [WebSocket & JS] Use a websocket module that doesn't require native modules May 29, 2015
@amasad
Copy link
Contributor Author

amasad commented Jun 2, 2015

What I meant, is that it's easy to implement a websocket server without node c/c++ extensions. And I don't know why they have to be native. Anyways, I'm just being pedantic :P

@amasad amasad closed this as completed Jun 2, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jun 2, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants