-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert SafeAreaView to ES Module #31330
Comments
Hey! I'm a brazilian student and interested in starting contributing to open source software. I use React Native every day, so I think that it would be a good project to start. Can I start working on this issue? |
Yes! Thank you for offering! Just assigned! Question: were you not able to assign yourself? (Just trying to understand if I should change my issue description) |
Thank you! I was not able to assign myself. |
Summary: Convert SafeAreaView to ES Module (#31330). ## Changelog [General] [Changed] - Converted `SafeAreaView` to ES Module. Pull Request resolved: #31344 Test Plan: Tested that `npm test` passes. Reviewed By: kacieb Differential Revision: D27767463 Pulled By: lunaleaps fbshipit-source-id: fd3aee58ae6d621a292ff3360d8833f5e5007d52
Summary: Convert SafeAreaView to ES Module (facebook#31330). ## Changelog [General] [Changed] - Converted `SafeAreaView` to ES Module. Pull Request resolved: facebook#31344 Test Plan: Tested that `npm test` passes. Reviewed By: kacieb Differential Revision: D27767463 Pulled By: lunaleaps fbshipit-source-id: fd3aee58ae6d621a292ff3360d8833f5e5007d52
Looks like this is done, feel free to reopen if not! |
I want to get back to android activity from react-native activity using backkey . MainActivity.java
ReactNativeActivity.java
I also tried the following code in ReactNativeActivity.java
If I pressed the back button it didn't get back to android activity. How can I get back to android activity from react-native activity using backkey? |
Description
SafeAreaView is currently using CommonJS export, we'd like to update this to use ES modules. You can find more about the differences here: https://irian.to/blogs/what-are-cjs-amd-umd-and-esm-in-javascript/
Expected Results
A default exported SafeAreaView module and relevant updates from
require
toimport
(caveat: inline requires, which will should be updated torequire(...).default
.You can use
flow
to catch any callsites missed.Note
The text was updated successfully, but these errors were encountered: