Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--npm on new template project missing performance.now in runtime #32224

Closed
lunaleaps opened this issue Sep 16, 2021 · 5 comments
Closed

--npm on new template project missing performance.now in runtime #32224

lunaleaps opened this issue Sep 16, 2021 · 5 comments
Labels
release-blocking This is a release-blocking issue against current release candidate Resolution: Locked This issue was locked by the bot.

Comments

@lunaleaps
Copy link
Contributor

Version

0.66.0-rc.2

Build Target(s)

Android, iOS

Developer Environment

Intel, macOS

Issue and Reproduction Steps

Steps to repro

In terminal

$ npx react-native init YARN662 --version 0.66.0-rc2
$ npx react-native init NPM662 --npm --version 0.66.0-rc2

# This works
$ cd YARN662 && npx react-native run-android # or run-ios

# This doesn't work
$ cd NPM662 && npx react-native run-android # or run-ios

Here is how the --npm flag is used in react-native-cli: https://github.com/react-native-community/cli/blob/641b21f583c97e3d48ce87d5fe804f42db92fa5c/packages/cli/src/commands/init/init.ts#L213

Attempting diffs of node_modules

diff RN662/node_modules NPM662/node_modules
diff -r RN66RC2/node_modules/react-native NPM662/node_modules/react-native

Outstanding questions -- to be investigated

  1. Is this issue unique to 0.66.0? 0.66.0-rc.2?
@lunaleaps
Copy link
Contributor Author

Tested on 0.65.1 and does not occur

@ShikaSD
Copy link
Contributor

ShikaSD commented Sep 18, 2021

The issue seems to be caused by @react-native-community/cli, where npm pulls in 0.65.1:

➜  NPM662 npm ls react-native
NPM662@0.0.1
└─┬ react-native@0.66.0-rc.3
  └─┬ @react-native-community/cli@6.0.0
    └── react-native@0.65.1

@Titozzz
Copy link
Collaborator

Titozzz commented Sep 22, 2021

@lunaleaps @ShikaSD fixed in CLI 6.0.1

@Titozzz Titozzz closed this as completed Sep 22, 2021
@fkgozali
Copy link
Contributor

We still need to verify if performance.now is now working with the CLI 6.0.1, I'll report back later.

@fkgozali
Copy link
Contributor

We still need to verify if performance.now is now working with the CLI 6.0.1, I'll report back later.

OK, I verified it worked properly with the CLI update

npx react-native init NPM66_3b --npm --version 0.66.0-rc.3

Verified peer deps:

npm ls react-native
npm66_3b@0.0.1 /Users/fkg/tmp/NPM66_3b
└─┬ react-native@0.66.0-rc.3
  └─┬ @react-native-community/cli@6.0.1
    └── react-native@0.66.0-rc.3 deduped

And building w/ Xcode and running it worked with no issue:

Simulator Screen Shot - iPhone 12 Pro - 2021-09-22 at 09 53 09

@facebook facebook locked as resolved and limited conversation to collaborators Sep 22, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-blocking This is a release-blocking issue against current release candidate Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants