Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Road to 0.66.0 #246

Closed
30 tasks done
lunaleaps opened this issue Aug 25, 2021 · 51 comments
Closed
30 tasks done

Road to 0.66.0 #246

lunaleaps opened this issue Aug 25, 2021 · 51 comments
Labels
pre-release rc Release candidate

Comments

@lunaleaps
Copy link
Collaborator

lunaleaps commented Aug 25, 2021

The branch cut has happened.

Notice

  • Current release candidate: v0.66.0
  • Have an issue with current release candidate? File an issue and we will triage.
  • Have a pick request for this release? Does it call under our pick request qualifications? If so please comment on this issue with the hash and justification.

Highlighted Changes in this release

Release Process

Checklist

When ready to publish stable

Retrospective Topics

  • We should update manual testing script to automatically build hermes versions of RNTestProject. Added support for RNTester in facebook/react-native@732ac17
  • We should audit the testing instructions, it mentions checking Chrome Debugger...which isn't a use-case anymore for RNTester and RNTestProject and we probably want Flipper instructions
  • @lunaleaps had bad experience with not being able to exit debugging experience on Android
  • @tido64 found issues on iOS with Image warning for unhandled promise?
  • Maybe we should add Release configuration tests to manual test script
  • We need a way to get sense of scale of people testing RC
  • Questions about Hermes debugging and new app screen, instructions on the new app screen don't make sense for new apps using Hermes?
  • Can we update react-native cli to allow option to create Hermes template app -- it'll make testing a little easier
  • Apple Silicon (M1) machines were still not widely available to help speed up testing needs (not many have one, Circle CI didn't have one either)

Release Status

0.66.0 (shipped!)


0.66.0-rc.4

  • Make a tweet about this when ready to get more signal
  • Upgrade upgrade-helper

Blocking issues for releasing 0.66.0-rc.4

Picks for 0.66.0-rc.4


0.66.0-rc.3

  • Make a tweet about this when ready to get more signal
  • Upgrade upgrade-helper

Blocking issues for releasing 0.66.0-rc.3

Picks for 0.66.0-rc.3


0.66.0-rc.2

Blocking issues for releasing 0.66.0-rc.2

  • Waiting on 0.9 release of Hermes
  • A question of Podfile.lock due to conflict from cherry-pick of Bump hermes cocoapod to 0.9.0: facebook/react-native@8e66f0b -- @lunaleaps not sure if I need to run pod update to commit

Picks for 0.66.0-rc.2


0.66.0-rc.1

Blocking issues for releasing 0.66.0-rc.1

Picks for 0.66.0-rc.1


0.66.0-rc.0

Picks that are in 0.66.0-rc.0

@lunaleaps lunaleaps added stable Stable version backport request Cherry picking a change into an existing release labels Aug 25, 2021
@lunaleaps lunaleaps changed the title V0.66.0 Discussion v0.66.0 Discussion Aug 25, 2021
@mikehardy

This comment has been minimized.

@lunaleaps lunaleaps changed the title v0.66.0 Discussion Road to 0.66.0 Aug 25, 2021
@NickGerleman

This comment has been minimized.

@lunaleaps lunaleaps added pre-release rc Release candidate and removed stable Stable version backport request Cherry picking a change into an existing release labels Aug 25, 2021
@kuasha420

This comment has been minimized.

@fkgozali

This comment has been minimized.

@heroic

This comment has been minimized.

@NickGerleman

This comment has been minimized.

@heroic

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali

This comment has been minimized.

@Huxpro

This comment has been minimized.

@r0b0t3d
Copy link

r0b0t3d commented Sep 3, 2021

Please pick facebook/react-native@7edf927

Fix keyboardDismissMode="on-drag" on Android

@tushar-singhal

This comment has been minimized.

@danilobuerger

This comment has been minimized.

@hsavit1

This comment has been minimized.

@lunaleaps

This comment has been minimized.

@lunaleaps
Copy link
Collaborator Author

0.66.0-rc2 is out: https://github.com/facebook/react-native/releases/tag/v0.66.0-rc.2

@swrobel

This comment has been minimized.

@miinos

This comment has been minimized.

@lunaleaps

This comment has been minimized.

@swrobel

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali
Copy link
Collaborator

0.66.0-rc.3 has been published! We decided to publish the next RC 3 to help validate the arm64 fix. Please give it a try.

The Upgrade Helper has been updated as well via react-native-community/rn-diff-purge@f848591

@DmytroKovalskyi-voypost

I have error with 0.66.0-rc.1 on ios build

sed: Pods/RCT-Folly/folly/portability/Time.h: No such file or directory

I think it caused that i run pod install not from ios folder,
i run it from project folder via

pod install --project-directory=ios

is it possible to check path in script something like ?

    if [[ -f ios/Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' ios/Pods/RCT-Folly/folly/portability/Time.h
    fi
    if [[ -f Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' Pods/RCT-Folly/folly/portability/Time.h
    fi

I had the similar issue during build after installing "0.66.0-rc.3" version : " 'boost/operators.hpp' file not found " . I believe boost pod wasn't completely installed due to large size, at least in my case. After that, i manually added used in previous versions pod 'boost-for-react-native' to Podfile . It's solved the build issue for now, but I think it could be a better solution for this .

@KingAmo
Copy link

KingAmo commented Sep 19, 2021

I have error with 0.66.0-rc.1 on ios build

sed: Pods/RCT-Folly/folly/portability/Time.h: No such file or directory

I think it caused that i run pod install not from ios folder,
i run it from project folder via
pod install --project-directory=ios
is it possible to check path in script something like ?

    if [[ -f ios/Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' ios/Pods/RCT-Folly/folly/portability/Time.h
    fi
    if [[ -f Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' Pods/RCT-Folly/folly/portability/Time.h
    fi

I had the similar issue during build after installing "0.66.0-rc.3" version : " 'boost/operators.hpp' file not found " . I believe boost pod wasn't completely installed due to large size, at least in my case. After that, i manually added used in previous versions pod 'boost-for-react-native' to Podfile . It's solved the build issue for now, but I think it could be a better solution for this .

i believe it is due to react-native-reanimated, i file a issue there software-mansion/react-native-reanimated#2434

@mikehardy

This comment has been minimized.

@fkgozali

This comment has been minimized.

@roots-ai

This comment has been minimized.

@mikehardy

This comment has been minimized.

@fkgozali
Copy link
Collaborator

@dmtrKovalenko @KingAmo I think facebook/react-native#32243 would help with your build issue, it will be in RC4

@numandev1

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali

This comment has been minimized.

@fkgozali
Copy link
Collaborator

v0.66.0-rc.4 has been published as a stable release candidate! It solved all known remaining issues in v0.66.0, so if this is stable, we plan to promote it to a stable release next week. Please try it out!

@joe-sam
Copy link

joe-sam commented Sep 28, 2021

Didn't see this make the list of cherry-pick request in the change log, so I'm guessing it was missed!
fix: compare the LogBoxData ignorePatterns with the right code (#31977)

@mikehardy
Copy link

@joe-sam the commit is facebook/react-native@a950634 - I'm guessing with rc4 already out for a few days and the RC process already having been quite long, that rc4 will ship and this will need a new notice on the 0.66.1 issue whenever that is created. Just a guess on my part, I am not a part of that process, just noting it so you keep on eye on things and re-post to 0.66.1 if needed. Cheers!

@kelset

This comment has been minimized.

@kelset
Copy link
Member

kelset commented Sep 29, 2021

as per conversation here: facebook/react-native#32284 (comment)
there won't be an RC5 with that extra commit - I'll hide my comment

@lunaleaps
Copy link
Collaborator Author

0.66.0 is out. Please see #254 for any issues

@react-native-community react-native-community locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pre-release rc Release candidate
Projects
None yet
Development

No branches or pull requests