Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.70.1 issue #34714

Closed
billnbell opened this issue Sep 17, 2022 · 6 comments
Closed

0.70.1 issue #34714

billnbell opened this issue Sep 17, 2022 · 6 comments
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@billnbell
Copy link
Contributor

billnbell commented Sep 17, 2022 •
edited
Loading

Description

└─┬ react-native@0.70.1
       ├─┬ @react-native-community/cli@9.1.1
        │      └─┬ @react-native-community/cli-plugin-metro@9.1.1
        │             └── metro-react-native-babel-transformer@0.72.3
       └── metro-react-native-babel-transformer@0.72.1

Notice react-native@0.70.1 has 2 versions of metro-react-native-babel-transformer which is causing issues on startup metro.

Version

0.70.1

Output of npx react-native info

See above

Steps to reproduce

Starting RN

Snack, code example, screenshot, or link to a repository

Screen Shot 2022-09-16 at 10 47 22 PM
@billnbell
Copy link
Contributor Author 

-    "@react-native-community/cli": "^9.0.0",
-    "@react-native-community/cli-platform-android": "^9.0.0",
-    "@react-native-community/cli-platform-ios": "^9.0.0",
+    "@react-native-community/cli": "9.0.0",
+    "@react-native-community/cli-platform-android": "9.0.0",
+    "@react-native-community/cli-platform-ios": "9.0.0",

@billnbell
Copy link
Contributor Author

Actually not able to fix it... Trying to eliminate multiple metros is difficult.

@billnbell
Copy link
Contributor Author

I cleaned and it went away after downgrading to "metro-react-native-babel-preset": "0.72.1",

@billnbell
Copy link
Contributor Author

I would still recommend that we go thru the dependent packages and those that are auto-upgrading to 0.72.3 should be set to not upgrade. Hence the removal of "^". But we need to check all of them to be consistent to 0.72.1. Or we should rush out a new build for 0.72.3 metro.

@cortinico
Copy link
Contributor

Just a heads up: we're aware of this issue
reactwg/react-native-releases#34 (comment)

We'll be fixing it most likely in 0.70.2

@kelset kelset mentioned this issue Sep 27, 2022
Closed
facebook-github-bot pushed a commit that referenced this issue Sep 30, 2022
@kelset @facebook-github-bot
chore(deps): bump CLI to 9.1.3 and Metro to 0.72.3 (#34803)
f164556 
Summary:
This PR bumps the dep version of Metro and the RN CLI to latest, and realigns them to avoid the issue we currently have in 0.70: #34714 (this commit will be cherry-picked there)

Also, it pins it all down to precise version. See comments for reasoning.

While at it, I gave a cleanup pass to the yarn.lock with [`yarn deduplicate`](https://github.com/scinos/yarn-deduplicate#readme).

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Changed] - bump CLI to 9.1.3 and Metro to 0.72.3

Pull Request resolved: #34803

Test Plan: CI is green

Reviewed By: dmytrorykun

Differential Revision: D39967392

Pulled By: dmytrorykun

fbshipit-source-id: 799dd745834c9ba349362f70afb4bdbd1a48260e
kelset added a commit that referenced this issue Oct 3, 2022
@kelset
chore(deps): bump CLI to 9.1.3 and Metro to 0.72.3 (#34803)
2de4cf0 
Summary:
This PR bumps the dep version of Metro and the RN CLI to latest, and realigns them to avoid the issue we currently have in 0.70: #34714 (this commit will be cherry-picked there)

Also, it pins it all down to precise version. See comments for reasoning.

While at it, I gave a cleanup pass to the yarn.lock with [`yarn deduplicate`](https://github.com/scinos/yarn-deduplicate#readme).

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Changed] - bump CLI to 9.1.3 and Metro to 0.72.3

Pull Request resolved: #34803

Test Plan: CI is green

Reviewed By: dmytrorykun

Differential Revision: D39967392

Pulled By: dmytrorykun

fbshipit-source-id: 799dd745834c9ba349362f70afb4bdbd1a48260e

# Conflicts:
#	package.json
#	template/package.json
#	yarn.lock
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 19, 2023
@kelset kelset closed this as completed Mar 20, 2023
@facebook facebook locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cortinico @kelset @billnbell