Multiple "NodePath has been removed so is read-only." errors #41929
Comments
wojtekmaj
added
Needs: Triage 🔍
Type: Upgrade Issue
github-actions
bot
added
Needs: Author Feedback
Needs: Repro
|
|
I looked into @babel/traverse source code (appeared to be the source of this error) and added console.trace() before the error in question is thrown. This is what I got: |
github-actions
bot
added
Needs: Attention
|
Not sure if this is harmful in any way, but found out that installing RN right now causes two copies of |
|
That would be bad. Who depends on *? |
|
The whole tree of YOLO version resolution: All of the * above are resolved to 0.74.0 at the moment of writing. |
|
I can confirm it's a dependency issue indeed! Adding the following Yarn resolutions: fixed the issue for me. 🥳 |
Yes, this is bad. Specifically we should get rid of this: |
|
This is a nice cleanup if someone wants to help us do it. Specifically we'll have to cleanup the following |
|
0.74.0? Not 0.73.x? |
|
We need to update the versions on main to point to 0.74.x. The ones on the 0.73 branch need to point to latest 0.73. I'll put up a PR #42081 for main |
Summary: See #41929 for an issue on multiple monorepo packages being installed. The reason is that `*` resolves to whatever is tagged `latest` on npm. We still need to fix the fact that our monorepo publish script will update the latest tag everytime we publish. For now, we should remove these from `main` and we will also update this in the 0.73 release branch. I've left the two peer dependencies on `react-native` to keep at `*`. ``` virtualized-lists/package.json 30: "react-native": "*" rn-tester/package.json 32: "react-native": "*" ``` As a peer-dependency this won't be a problem in terms of installing a second `react-native`. I thought about updating these to `nightly`, but that would install multiple nightly react-natives as the tag will be updated with each nightly release. I think for now this is fine and something we can revisit. Things left to do [ ] Fix monorepo publish script to not update `--latest` [ ] Remove ^ dependencies on monorepo packages: #41958 [ ] Re-evaluate how we bump and align monorepo packages when we cut a release branch. I forget if we manually update this when we cut or if there is a script. We may want to change the script and have `main` dependencies point to some fake version like `1000.0.0` and only update these on nightly publishes. Regardless, this will need some discussion. ## Changelog: [GENERAL] [CHANGED] - Be explicit about what monorepo versions we are using Pull Request resolved: #42081 Test Plan: N/A Reviewed By: cortinico, cipolleschi Differential Revision: D52435234 Pulled By: lunaleaps fbshipit-source-id: 67da029d2b637e3997c12c21fe2a9ab9bc344399
|
@wojtekmaj 0.73.2 was released which removes the |
|
Yep, I can confirm that removing the previously added workaround:
and removing references to these packages from lockfile, and reinstalling the repo, results in correct versions of these packages installed: 0.73.19, 0.73.2 and 0.73.2 respectively. There are no copies of @react-native/babel-plugin-codegen @0.74.x in my dependency tree either. Thanks! |
cortinico
added
Resolution: Fixed
Summary: See facebook#41929 for an issue on multiple monorepo packages being installed. The reason is that `*` resolves to whatever is tagged `latest` on npm. We still need to fix the fact that our monorepo publish script will update the latest tag everytime we publish. For now, we should remove these from `main` and we will also update this in the 0.73 release branch. I've left the two peer dependencies on `react-native` to keep at `*`. ``` virtualized-lists/package.json 30: "react-native": "*" rn-tester/package.json 32: "react-native": "*" ``` As a peer-dependency this won't be a problem in terms of installing a second `react-native`. I thought about updating these to `nightly`, but that would install multiple nightly react-natives as the tag will be updated with each nightly release. I think for now this is fine and something we can revisit. Things left to do [ ] Fix monorepo publish script to not update `--latest` [ ] Remove ^ dependencies on monorepo packages: facebook#41958 [ ] Re-evaluate how we bump and align monorepo packages when we cut a release branch. I forget if we manually update this when we cut or if there is a script. We may want to change the script and have `main` dependencies point to some fake version like `1000.0.0` and only update these on nightly publishes. Regardless, this will need some discussion. ## Changelog: [GENERAL] [CHANGED] - Be explicit about what monorepo versions we are using Pull Request resolved: facebook#42081 Test Plan: N/A Reviewed By: cortinico, cipolleschi Differential Revision: D52435234 Pulled By: lunaleaps fbshipit-source-id: 67da029d2b637e3997c12c21fe2a9ab9bc344399
|
I'm seeing this issue arise on 0.73.6 in an nx monorepo. Possible regression? Should I raise a new issue? |
|
Seeing this when running tests on 0.73.6 |
|
@PaulCunningham697 I finally got over this by matching the babel versions in my dependency declarations to the correct metro versions. What do you have for those? |
|
I am also experiencing this issue on 0.73.6. These are my package.json dependenciesL |
|
Did you manage to solve the error? I have the same one right now updating from 0.72 to 0.73 |
Did you manage to solve it? |
Did you manage to solve it? |
Can you share your package.json please. |
|
@CCB-cerivera here's my package.json and I'm not seeing the issue anymore |
|
Thank you, I have verified and it still gives me the same error. Anything else you've tried as configuring babel.config.js or metro.config.js? |
|
I'm facing the same issue after updating from 0.71.8 to 0.73.6. Here are my NPM dependencies: |
|
Did you manage to solve it? It's been 6 days now and I can't find a solution. |
|
Even without solving the problem, I share the error log:
|
|
For those who have this problem, it is because there is some kind of conflict with |
@wojtekmaj What file did you make these changes in? |
This worked for me! Thank you for sharing |
Old Version
0.72.7
New Version
0.73.0
Description
Upon starting the app (in dev mode), it starts bundling the modules, and then crashes with one of the following errors:
Steps to reproduce
Affected Platforms
Runtime - iOS
Output of
npx react-native infoStacktrace or Logs
Reproducer
I have no idea how to reproduce that on other apps :( The errors seem to be coming from everywhere, there are no error stacks, I don't know what to add to break it.
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: