-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【iOS】The contentOffset property is missing from TextInputView's onScroll callback #43428
Labels
Component: TextInput
Related to the TextInput component.
Platform: iOS
iOS applications.
Resolution: PR Submitted
A pull request with a fix has been provided.
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
Comments
rabbitmouse
added
Needs: Triage 🔍
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
labels
Mar 12, 2024
|
github-actions
bot
added
Needs: Repro
This issue could be improved with a clear list of steps to reproduce the issue.
Newer Patch Available
labels
Mar 12, 2024
|
github-actions
bot
added
Component: TextInput
Related to the TextInput component.
Platform: iOS
iOS applications.
labels
Mar 12, 2024
@rabbitmouse thanks for your report. Can you provide:
And then we could look into it |
Yes I think this submission is correct, thx |
github-actions
bot
added
Needs: Attention
Issues where the author has responded to feedback.
and removed
Needs: Author Feedback
labels
Mar 13, 2024
cortinico
added
Resolution: PR Submitted
A pull request with a fix has been provided.
and removed
Needs: Repro
This issue could be improved with a clear list of steps to reproduce the issue.
Newer Patch Available
Needs: Attention
Issues where the author has responded to feedback.
labels
Mar 13, 2024
cipolleschi
pushed a commit
that referenced
this issue
Jun 3, 2024
Summary: Fixes #43428 . cc cortinico . ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes textinput onscroll event payload Pull Request resolved: #43445 Test Plan: ``` const onInputScroll = (e) => { if (Platform.OS !== "web") { const { nativeEvent: { contentOffset: { x, y }, }, } = e; console.log('onInputScroll ====', e?.nativeEvent) } }; <TextInput onScroll={onInputScroll} // ref={inputRef} multiline /> ``` Reviewed By: cortinico Differential Revision: D54813378 Pulled By: sammy-SC fbshipit-source-id: 76671fbb390c2fbc67a9c29b6c2a834ba699fff4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: TextInput
Related to the TextInput component.
Platform: iOS
iOS applications.
Resolution: PR Submitted
A pull request with a fix has been provided.
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
Description
I found that in the onScroll callback of textInput, the old schema contained the contentOffset attribute, but the new schema did not, causing a crash!
Steps to reproduce
React Native Version
0.73.3
Affected Platforms
Runtime - iOS
Areas
Fabric - The New Renderer
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/rabbitmouse
Screenshots and Videos
The old architecture scroll callback is as shown below
The new architecture scroll callback is as shown below
I confirm that this is still described in the official documentation.
Please fix it as soon as possible!
The text was updated successfully, but these errors were encountered: