Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.74] Cannot access Dev Menu on Android (RNTester) #43451

Closed
huntie opened this issue Mar 12, 2024 · 4 comments
Closed

[0.74] Cannot access Dev Menu on Android (RNTester) #43451

huntie opened this issue Mar 12, 2024 · 4 comments
Assignees
@cortinico
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. release-blocking This is a release-blocking issue against current release candidate Resolution: PR Submitted A pull request with a fix has been provided.

Comments

@huntie
Copy link
Member

huntie commented Mar 12, 2024

Description

I'm unable to access the Dev Menu on Android using the keyboard shortcut trigger.

Screen.Recording.2024-03-12.at.18.49.01.mov

Steps to reproduce

I tested from the react-native repo (main and 0.74-stable branches).

  1. Install RNTester on a local Android emulator.

    cd packages/react-native/
yarn android

  2. Attempt to open Dev Menu:

    • Cmd + M shortcut
    • adb shell input keyevent 82

React Native Version

0.74.0-rc.2

Affected Platforms

Runtime - Android

Output of npx react-native info

info Fetching system and libraries information...
System:
  OS: macOS 14.4
  CPU: (10) arm64 Apple M1 Pro
  Memory: 142.77 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.18.2
    path: ~/.nvm/versions/node/v18.18.2/bin/node
  Yarn:
    version: 1.22.19
    path: ~/homebrew/bin/yarn
  npm:
    version: 9.8.1
    path: ~/.nvm/versions/node/v18.18.2/bin/npm
  Watchman:
    version: 2024-03-11T04:15:49Z
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/huntie/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10406996
  Xcode:
    version: 15.1/15C65
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /Users/huntie/.jenv/shims/javac
  Ruby:
    version: 2.7.4
    path: /Users/huntie/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: false
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

–

Reproducer

https://github.com/facebook/react-native/tree/main/packages/rn-tester

Screenshots and Videos

No response
@github-actions github-actions bot added Platform: Android Android applications. Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Mar 12, 2024
@github-actions GitHub Actions
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@huntie huntie added release-blocking This is a release-blocking issue against current release candidate and removed Platform: Android Android applications. Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Mar 12, 2024
@huntie huntie added the Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. label Mar 12, 2024
@cortinico
Copy link
Contributor

Tested both on main and on the release branch and cannnot reproduce:

main

Screen.Recording.2024-03-13.at.11.57.04.mov

0.74-branch

Screen.Recording.2024-03-13.at.12.02.11.mov

@huntie
Copy link
Member Author

huntie commented Mar 13, 2024

@cortinico Thanks for following up, however your videos appear to be using the d key handler in the dev server. Instead, can you try using the command + M shortcut in the Android app, per repro steps?

@cortinico cortinico mentioned this issue Mar 13, 2024
Closed
cortinico added a commit to cortinico/react-native that referenced this issue Mar 13, 2024
@cortinico @facebook-github-bot
Properly handle RR and CMD+M in Bridgeless Mode
2f43905 
Summary:
Currently pressing the menu button (or CMD+M) is broken on Bridgeless mode.
Also pressing RR is not reloading the App.
That's because some Bridgeless API haven't been reimplemented correctly on Android. I'm fixing them here.

Fixes facebook#43451

Changelog:
[Android] [Fixed] - Properly handle RR and CMD+M in Bridgeless Mode

Differential Revision: D54852959
@cortinico
Copy link
Contributor

Yup you're right. Fix is here:

@cortinico cortinico added Resolution: PR Submitted A pull request with a fix has been provided. and removed Needs: Triage 🔍 labels Mar 13, 2024
@cortinico cortinico self-assigned this Mar 13, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.74 Releases Mar 13, 2024
@huntie huntie moved this from Done / Picked to Inbox in React Native 0.74 Releases Mar 18, 2024
@huntie huntie moved this from Inbox to Done / Picked in React Native 0.74 Releases Mar 18, 2024
huntie pushed a commit that referenced this issue Mar 18, 2024
@cortinico @huntie
Properly handle RR and CMD+M in Bridgeless Mode (#43460)
0f4aedf 
Summary:
Pull Request resolved: #43460

Currently pressing the menu button (or CMD+M) is broken on Bridgeless mode.
Also pressing RR is not reloading the App.
That's because some Bridgeless API haven't been reimplemented correctly on Android. I'm fixing them here.

Fixes #43451

Changelog:
[Android] [Fixed] - Properly handle RR and CMD+M in Bridgeless Mode

Reviewed By: huntie

Differential Revision: D54852959

fbshipit-source-id: 8fbbdab6818da9177e6db40e45d35258c7f5e236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cortinico cortinico

Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. release-blocking This is a release-blocking issue against current release candidate Resolution: PR Submitted A pull request with a fix has been provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly handle RR and CMD+M in Bridgeless Mode cortinico/react-native
2 participants
@huntie @cortinico