Android - Composer - Previous text is cut off after creating next line

[gedu]

Description

When the TextInput component is controlled and the multiline prop is set to true, the text gets cut off after writing some text and adding a new line. However, when a new character is added, the text displays correctly.

Steps to reproduce

1. Add a TextInput
2. set the value prop and onChangeText
3. set as true the multiline prop
4. Add some text
5. Add a new line, tapping the Enter button on the keyboard
6. The text is cut off

React Native Version

0.74.3

Affected Platforms

Runtime - Android

Output of npx react-native info

System:
  OS: macOS 13.6.7
  CPU: (10) arm64 Apple M1 Pro
  Memory: 41.83 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.14.0
    path: ~/.nvm/versions/node/v20.14.0/bin/node
  Yarn:
    version: 1.22.22
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.7.0
    path: ~/.nvm/versions/node/v20.14.0/bin/npm
  Watchman:
    version: 2023.11.27.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/eduardograciano/.gem/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10671973
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.7.5
    path: /Users/eduardograciano/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: false
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

-

Reproducer

https://github.com/gedu/android-composer-reproducer

Screenshots and Videos

android_composer_cutoff_multiline.mp4

[github-actions]

⚠️	Add or Reformat Version Info
ℹ️	We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.70.2

[shubhamguptadream11]

@gedu I checked this, it is reproducible in new architecture working correctly in old one.
@cortinico I am looking into this.

[shubhamguptadream11]

@cortinico While debugging this I found this TODO:

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

Line 1342 in 245e5d9

// TODO T58784068: move this constructor once Fabric is shipped

Here we are setting padding to zero.
Where do we need to move this code block?

[j-piasecki]

I think it's the same issue as this PR is fixing - #42331

[shubhamguptadream11]

@j-piasecki I think your forked repo is not in sync with main one.
This file:
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java no longer exists currently.
Also the code in this file changed:
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java
Can you just check once. I am trying to test this fix.