Add a workaround for text being measured incorrectly when ending with an empty line

[j-piasecki]

Summary:

It looks like StaticLayout used for measuring multiline text on the new architecture returns wrong metrics for the last line if it's empty, however, if it contains anything, then the returned values are correct.

Similar approach with measuring I was already used in ReactEditText:

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Lines 1203 to 1213 in 258d8e5

	// If we don't have text, make sure we have *something* to measure.
	// Hint has the same dimensions - the only thing that's different is background or foreground
	// color
	if (!haveText) {
	if (getHint() != null && getHint().length() > 0) {
	sb.append(getHint());
	} else {
	// Measure something so we have correct height, even if there's no string.
	sb.append("I");
	}
	}

Changelog:

[ANDROID] [FIXED] - Fixed text being measured incorrectly when ending with an empty line on the new architecture

Test Plan:

I tested the change on this simple code on React Native 0.73.2 (with the new arch enabled)

import React from 'react';
import {useState} from 'react';
import {SafeAreaView, TextInput} from 'react-native';

export default function App() {
  const [text, setText] = useState('ABC\nDEF\nGHI\n');

  return (
    <SafeAreaView style={{flex: 1}}>
      <TextInput
        value={text}
        onChangeText={setText}
        style={{borderWidth: 1, margin: 20, padding: 30}}
        multiline
      />
    </SafeAreaView>
  );
}

Before:

Screen.Recording.2024-01-17.at.13.10.09.mov

After:

Screen.Recording.2024-01-17.at.13.07.46.mov

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,798,999	+7
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,190,313	-5
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 6c8dfc8
Branch: main

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[j-piasecki]

Not stale

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cortinico merged this pull request in bd32392.

[react-native-bot]

This pull request was successfully merged by @j-piasecki in bd32392

^{When will my fix make it into a release? | How to file a pick request?}

[NickGerleman]

FYI that #46613 replaces this logic with a proper fix (we were not correctly propagating settings to TextPaint used for layout)