Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketRocket: app store rejection #459

Closed
tptee opened this issue Mar 29, 2015 · 4 comments
Closed

SocketRocket: app store rejection #459

tptee opened this issue Mar 29, 2015 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@tptee
Copy link

tptee commented Mar 29, 2015

There's reports on SocketRocket's repo that the _connect method in SocketRocket resembles a private API method and doesn't pass iTunes Connect validation:r

facebookincubator/SocketRocket#226

@sahrens
Copy link
Contributor

sahrens commented Mar 29, 2015

SocketRocket is only needed for debugging - you shouldn't have to include it in your final app submission if you run into any issues with this.

On Mar 29, 2015, at 3:01 PM, Tyler Paul Thompson notifications@github.com wrote:

There's reports on SocketRocket's repo that the _connect method in SocketRocket resembles a private API method and doesn't pass iTunes Connect validation:r

facebookincubator/SocketRocket#226


Reply to this email directly or view it on GitHub.

@tptee
Copy link
Author

tptee commented Mar 29, 2015

Cool, thanks for the heads-up!

On Mar 29, 2015, at 6:15 PM, Spencer Ahrens notifications@github.com wrote:

SocketRocket is only needed for debugging - you shouldn't have to include it in your final app submission if you run into any issues with this.

On Mar 29, 2015, at 3:01 PM, Tyler Paul Thompson notifications@github.com wrote:

There's reports on SocketRocket's repo that the _connect method in SocketRocket resembles a private API method and doesn't pass iTunes Connect validation:r

facebookincubator/SocketRocket#226


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub #459 (comment).

@frantic
Copy link
Contributor

frantic commented Mar 30, 2015

@a2 - would you remind me how you did DEBUG/prod configuration for linking libraries? We would like to link libRCTWebSocketDebugger only for DEBUG builds

@a2
Copy link
Contributor

a2 commented Mar 30, 2015

You would want to set add the -lRCTWebSocketDebugger build flag only in DEBUG. If you use CocoaPods, this becomes much easier as you can set up a debug-only dependency using the following in your Podfile:

pod 'React/RCTWebSocketDebugger', :configurations => ['Debug']

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants