-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator: Change transition color #563
Comments
This would be extremely helpful. I hope this gets added! |
Something to consider - should this be a property of the navigator's style? |
Good point @ide. On second thought it would seem to make more sense that way |
Actually, there will be challenges if you try to put it on styles. It is kind of a special prop because we can't rely on it being an object (Stylesheet converts them into numbers for safety and optimization) If we add This is the API we want:
I haven't tried, but what if the default transitioner style is 'transparent'? Does that make this work? |
@ericvicenti just tried and that didn't work. The transition background always ends up white. Edit: Ooops, on second look that does actually work. I'll update my PR |
Hmm, I wonder what is causing it to be white.. cc @vjeux , this is one of those rare cases where we actually want the 'cascade' of CSS. What should we do in these cases? Although it is a bit funky, this would probably be the most consistent with everything else we do:
|
Oh, @jlevine22, I didn't see your edit. Great news! |
Summary: ... for setting the transition background color between scenes. For issue facebook#563 Closes facebook#654 Github Author: Josh Levine <josh.levine1@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: ... for setting the transition background color between scenes. For issue facebook#563 Closes facebook#654 Github Author: Josh Levine <josh.levine1@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: ... for setting the transition background color between scenes. For issue facebook#563 Closes facebook#654 Github Author: Josh Levine <josh.levine1@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Shouldn't this be documented? |
Is there no way to change the background color on transitions between scenes in a Navigator component? I've dug into the code and it seems like the color value is hard coded.
I've played around with adding this feature as a property on a Navigator (transitionBackgroundColor={'#FFFFFF'}). But I want to make sure this doesn't already exist before issuing a pull request.
The text was updated successfully, but these errors were encountered: