Running `flow` inside a brand new project fails #784

jergason · 2015-04-09T22:23:00Z

Steps to reproduce:

react-native init someproject && cd someproject
flow init
flow
Cry because there are 438 errors.

I am on OS X 10.10.2, iojs 1.6.3, react-native 0.3.10, and flow 0.8.

Here is the JSON from the first few errors:

{
  "passed": false,
  "errors": [
    {
      "message": [
        {
          "descr": "NativeModules\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/ActionSheetIOS/ActionSheetIOS.js",
          "line": 14,
          "endline": 14,
          "start": 29,
          "end": 52
        }
      ]
    },
    {
      "message": [
        {
          "descr": "invariant\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/ActionSheetIOS/ActionSheetIOS.js",
          "line": 16,
          "endline": 16,
          "start": 17,
          "end": 36
        }
      ]
    },
    {
      "message": [
        {
          "descr": "NativeModules\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/AdSupport/AdSupportIOS.js",
          "line": 14,
          "endline": 14,
          "start": 17,
          "end": 40
        }
      ]
    },
    {
      "message": [
        {
          "descr": "NativeModules\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/Animation/AnimationExperimental.js",
          "line": 14,
          "endline": 14,
          "start": 27,
          "end": 50
        }
      ]
    },
    {
      "message": [
        {
          "descr": "AnimationUtils\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/Animation/AnimationExperimental.js",
          "line": 15,
          "endline": 15,
          "start": 22,
          "end": 46
        }
      ]
    },
    {
      "message": [
        {
          "descr": "identifier __DEV__\nUnknown global name",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/Animation/AnimationExperimental.js",
          "line": 75,
          "endline": 75,
          "start": 5,
          "end": 11
        }
      ]
    },
    {
      "message": [
        {
          "descr": "ReactPropTypes\nRequired module not found",
          "code": 0,
          "path": "/Users/jergason/code/flowbreaks/node_modules/react-native/Libraries/Animation/LayoutAnimation.js",
          "line": 14,
          "endline": 14,
          "start": 17,
          "end": 41
        }
      ]
    },
// etc
  ]
}

The text was updated successfully, but these errors were encountered:

frantic · 2015-04-10T00:24:28Z

We are going to provide a flowconfig with sample app soon. cc @sahrens

bhosmer · 2015-04-10T00:28:02Z

HI @jergason - so the problem is that flow init writes an empty .flowconfig into the root of the new project directory. (react-native init should instead write one that's set up properly, but per @frantic, that's not happening just yet.)

For now, the workaround is to copy the .flowconfig from the root of react-native into your project directory and tweak it, by replacing the two lines in the [library] section with this one:

node_modules/react-native/Libraries/react-native/react-native-interface.js

That should get you to 0 errors using Flow 0.8.0.

sthomp · 2015-04-18T22:43:26Z

Im still having issues getting flow to run without errors. After I react-native init hello I can see there is a .flowconfig provided. But when I run flow I see errors. Currently using flow 0.9.2.

{  
   "status":500,
   "message":"Flow found type errors.  If you think these are wrong, make sure your flow bin and .flowconfig are up to date, or disable with --skipflow.",
   "type":"FlowError",
   "errors":[  
      {  
         "description":"E1: function call\nCallable signature not found in",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/AppRegistry/AppRegistry.js",
         "lineNumber":57,
         "column":9
      },
      {  
         "description":"  E1: exports",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/ReactIOS/renderApplication.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E2: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/ActivityIndicatorIOS/ActivityIndicatorIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E3: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/DatePicker/DatePickerIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E4: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/MapView/MapView.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E5: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/Navigation/NavigatorIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E6: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E7: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/SliderIOS/SliderIOS.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E8: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/StaticRenderer.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E9: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/SwitchIOS/SwitchIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E10: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/TabBarIOS/TabBarIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E11: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/TabBarIOS/TabBarItemIOS.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E12: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/TextInput/TextInput.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E13: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/Touchable/TouchableBounce.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E14: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/Touchable/TouchableWithoutFeedback.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E15: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/View/View.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E16: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/WebView/WebView.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E17: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Image/Image.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E18: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/ReactIOS/renderApplication.ios.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E19: property propTypes\nProperty not found in",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/ReactIOS/verifyPropTypes.js",
         "lineNumber":28,
         "column":10
      },
      {  
         "description":"  E19: exports",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Components/View/View.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E20: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/Text/Text.js",
         "lineNumber":0,
         "column":0
      },
      {  
         "description":"E21: \nFailure(\"internal error: package /Users/thompsons/node_modules/React/package.json not found\")",
         "filename":"/Users/thompsons/Code/reactjs/hello/node_modules/react-native/Libraries/react-native/react-native.js",
         "lineNumber":0,
         "column":0
      }
   ]
}

jergason · 2015-04-18T23:22:27Z

The default .flowconfig file isn't correct. See #784 (comment) for an explanation of how to get it running.

sthomp · 2015-04-19T17:58:08Z

Here is the .flowconfig that react-native generated which matches the comments above:

[ignore]

# We fork some components by platform.
.*/*.web.js
.*/*.android.js

# Some modules have their own node_modules with overlap
.*/node_modules/node-haste/.*

# Ignore react-tools where there are overlaps, but don't ignore anything that
# react-native relies on
.*/node_modules/react-tools/src/vendor/core/ExecutionEnvironment.js
.*/node_modules/react-tools/src/browser/eventPlugins/ResponderEventPlugin.js
.*/node_modules/react-tools/src/browser/ui/React.js
.*/node_modules/react-tools/src/core/ReactInstanceHandles.js
.*/node_modules/react-tools/src/event/EventPropagators.js

# Ignore jest
.*/react-native/node_modules/jest-cli/.*

[include]

[libs]
node_modules/react-native/Libraries/react-native/react-native-interface.js

[options]
module.system=haste

jasongonzales23 · 2015-04-25T16:20:59Z

Bump. Same issue. Using Flow 0.10.0

jasongonzales23 · 2015-04-25T16:23:29Z

uh, wow, I fixed it...?

[libs] should be [library]

Seems like a simple bugfix. Maybe I will dig in to this and fix it?

christopherdro · 2015-04-25T19:31:33Z

That results in the flow server not being able start.
.flowconfig:23 Unsupported config section: "library"

jasongonzales23 · 2015-04-25T19:34:30Z

Heh, yeah I noticed that too late. All I noticed was that the demo then worked, which I assume is because flow didn't run at all. So, I still don't know how to get flow working in this demo.

But for fun you could try the following instead of [libs]

[kittens]
[pygmygoats]
[ufos]

and they all have the same result!

christopherdro · 2015-04-25T19:50:36Z

This looks like the same as #912 #938.

The issue is not upgrading flow. Trying using 0.7.0 , or 0.8.0.

pavelnikolov · 2015-04-26T15:40:18Z

What is the best way to downgrade flow if I have version 0.10.0 installed with homebrew?

christopherdro · 2015-04-26T17:42:23Z

brew switch flow 0.8.0

If you don't have this version it will display what versions you have access to.

jasongonzales23 · 2015-04-26T17:53:59Z

No joy with 0.9.2, 0.8.0, 0.7.0.

christopherdro · 2015-04-27T15:45:57Z

@jasongonzales23 After downgrading flow make sure to cd into your proj directory then try restarting the flow server by using 'flow stop' and 'flow start'.

See if that helps.

@jergason Did you resolve this issue?

princeli · 2015-04-28T00:02:12Z

@jasongonzales23 thanks,it fix my error

gabelevi · 2015-04-28T03:53:09Z

Hi everyone, thanks for the reports and sorry that you guys are having trouble! I'm a member of the Flow team and we spent the last day looking into this issue. There are two problems being discussed in this issue, both regarding react-native and Flow having trouble working together. The two problems are:

People are having trouble using react-native 0.4.0 with Flow v0.10.0
People are experiencing other miscellaneous Flow errors

This evening we deployed react-native 0.4.1, which included the following changes:

Fixed the issues that Flow v0.10.0 noticed. react-native init yourproject should no longer generate a project with Flow errors (according to Flow v0.10.0)
Temporarily disabled the red-box error messages for Flow errors. Users will have to run flow manually to see Flow errors. We on the Flow team think react-native is pretty awesome and don't want to block anyone from trying it out while we figure out how to properly pin Flow versions to React.

Over the next week I'm going to try and tackle this problem of making sure that people use the right version of Flow with each version of react-native. Here are my tentative plans:

Introduce an option to turn the flow checks on/off when you run your react-native app (and thus whether to show the red box)
react-native init generates this .flowconfig file which configures Flow for your new project. I'm going to make the .flowconfig file specify exactly which version of Flow your project expects. That way if you're running the wrong version of Flow you'll know immediately, rather than having to guess from some strange error message
I'm going to add flow-bin as a npm dependency. flow-bin is a pseudo npm package that downloads the correct binary from GitHub based on the version number and your operating system. This way the react-native packager can always use the correct version of Flow when doing it's Flow checking.

So yeah, sorry for the pain, thanks for the report, and look for some related improvements shortly!

brentvatne · 2015-04-28T05:34:57Z

Thanks @gabelevi! Your plan sounds good to me 👍

watsonwu9 · 2015-04-30T09:44:16Z

@christopherdro that fixed my error. thanks!

watsonwu9 · 2015-04-30T11:16:46Z

@jasongonzales23 fixed my problem. thx

christopherdro · 2015-04-30T17:05:47Z

@jergason Please close this issue since it has been resolved.
Thanks @gabelevi!

atticoos · 2015-12-23T16:40:40Z

This appears to have become an issue again on 0.17.0 of RN.

The .flowconfig requires flow at 0.19.0, which I have installed, yet it fails to resolve any react native modules:

This can be reproduced on a fresh project.

klvnptr · 2015-12-31T11:40:50Z

+1

brenmcnamara · 2016-01-02T20:53:43Z

+1

atticoos · 2016-01-03T01:12:20Z

I feel like I have nowhere to start with using Flow right now. Has anyone got an RN project running with Flow?

brentvatne · 2016-01-03T03:28:38Z

cc @vjeux ^

vjeux · 2016-01-03T03:44:33Z

@gabelevi is the right person to talk to about flow :)

satya164 · 2016-01-03T04:38:26Z

@gabelevi Lemme know if you need help with testing this. I've a project already setup with flow.

artyomtrityak · 2016-01-16T00:14:31Z

+1, it looks like flow just does not work with RN from the box right now, any suggestions how to fix this?
All errors i see are related to require('NativeModules')

artyomtrityak · 2016-01-16T04:50:05Z

There is one solution i can propose to fix this issue - it is possible to create interface file for react-native and ExecutionEnvironment.

interfaces/react-native.js

declare module "react-native" {
  declare var exports: (callback: any) => any;
}

declare module ExecutionEnvironment {
  declare var exports: (callback: any) => any; 
}

and add to .flowconfig

[libs]
interfaces/
....
[ignore]
.*/node_modules/react-native/.*
....

[version]
0.20.1

This works for me right now, i can create pull request to update yeoman generator

Emilios1995 · 2016-02-28T06:33:11Z

👍
I would love complete support out of the box. Right now I get the following out of a new project

atticoos · 2016-02-28T07:13:17Z

This seems to be working for 0.21.0-rc on a fresh project. What version of RN is that @Emilios1995?

cupofjoakim · 2016-07-13T08:28:15Z

Also on a pretty new project over here, getting 19 errors from running 'flow'.
RN @ 0.29.0
flow-bin @ 0.28.0

Here's the output

phil-travelbytes · 2016-07-15T03:33:41Z

+1 (agree with cupofjoakim, have issue with default project seed)

luiswdy · 2016-07-20T04:15:28Z

+1. I got as same issue as the one cupofjoakim reported.

phil-travelbytes · 2016-07-20T05:17:34Z

The 'init' project creates a .flowconfig which specifies [version] 0.27.0 - which works according to Michael Helvey in this stackoverflow post.

The actual issue for me is that flow binaries are not available in brew for back sourcing. I have flow version 0.23.1 and now 0.28, and 0.29.

brew upgrade flow --version 0.27.0
Error: No available formula with the name "0.27.0"

If these were available it would be simple to regress flow to the correct version, and then happy days :)

satya164 · 2016-07-20T13:05:20Z

@phil-travelbytes

npm install flow-bin@0.27.0

phil-travelbytes · 2016-07-22T03:05:29Z

@satya164 thank you!
Works a treat running via <PROJECT_ROOT>/node_modules/.bin/flow ...

but how do I include it in Nuclide?

satya164 · 2016-07-22T11:10:05Z

Nuclide doesn't support it yet. But support is coming - https://twitter.com/natmote/status/755871913864466433

justin808 · 2016-07-25T02:54:19Z

Any recommendations if flow should be a dev dependency of a react-native project? I'm guessing yes, since the eslint version very sensitive.

mt81 · 2016-08-03T15:49:50Z

+1

hramos · 2016-11-01T21:49:42Z

Looks like this can be closed as well (see #8773).

brentvatne mentioned this issue Apr 12, 2015

Add .flowconfig to SampleApp so it will be included with react-native init #818

Closed

christopherdro mentioned this issue Apr 25, 2015

Flow Type Errors Examples/UIExplorer #938

Closed

jergason closed this as completed Apr 30, 2015

satya164 reopened this Dec 23, 2015

satya164 added JavaScript Tooling labels Jan 1, 2016

hramos closed this as completed Nov 1, 2016

facebook locked as resolved and limited conversation to collaborators Jul 23, 2018

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018

Running flow inside a brand new project fails #784

Running flow inside a brand new project fails #784

Comments

jergason commented Apr 9, 2015

frantic commented Apr 10, 2015

bhosmer commented Apr 10, 2015

sthomp commented Apr 18, 2015

jergason commented Apr 18, 2015

sthomp commented Apr 19, 2015

jasongonzales23 commented Apr 25, 2015

jasongonzales23 commented Apr 25, 2015

christopherdro commented Apr 25, 2015

jasongonzales23 commented Apr 25, 2015

christopherdro commented Apr 25, 2015

pavelnikolov commented Apr 26, 2015

christopherdro commented Apr 26, 2015

jasongonzales23 commented Apr 26, 2015

christopherdro commented Apr 27, 2015

princeli commented Apr 28, 2015

gabelevi commented Apr 28, 2015

brentvatne commented Apr 28, 2015

watsonwu9 commented Apr 30, 2015

watsonwu9 commented Apr 30, 2015

christopherdro commented Apr 30, 2015

atticoos commented Dec 23, 2015

klvnptr commented Dec 31, 2015

brenmcnamara commented Jan 2, 2016

atticoos commented Jan 3, 2016

brentvatne commented Jan 3, 2016

vjeux commented Jan 3, 2016

satya164 commented Jan 3, 2016

artyomtrityak commented Jan 16, 2016

artyomtrityak commented Jan 16, 2016

Emilios1995 commented Feb 28, 2016

atticoos commented Feb 28, 2016

cupofjoakim commented Jul 13, 2016 • edited Loading

phil-travelbytes commented Jul 15, 2016

luiswdy commented Jul 20, 2016

phil-travelbytes commented Jul 20, 2016

satya164 commented Jul 20, 2016

phil-travelbytes commented Jul 22, 2016

satya164 commented Jul 22, 2016

justin808 commented Jul 25, 2016

mt81 commented Aug 3, 2016

hramos commented Nov 1, 2016

Running `flow` inside a brand new project fails #784

Running `flow` inside a brand new project fails #784

cupofjoakim commented Jul 13, 2016 •

edited

Loading