-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefreshControl showing issue on RN 0.27 #7976
Comments
I'm getting the exact same thing in iOS simulator. Using:
It disappears once the view gets touched. |
Temporary fix — remove |
Same issue, I fix removing |
Do you know if this issue only happens since 0.27? |
@janicduplessis I'm not sure, we skipped 0.26.x versions due to various bugs. 0.25.x was working fine. |
@janicduplessis I was on 0.26.3 before it was fine! Without the title attribute it doesn't happen anymore. |
Same issue here with tintColor |
@janicduplessis it is 0.27 only issue. |
0.28.0 happens too! |
I'm facing this issue with RN 28.0 even if I remove tintColor and title:
does anyone has a working temporary (or better a stable) fix for this? |
As a temporary fix I just set the background color of my row, or header or whatever you have at the top of the list view on your app. I take a look in the |
same issue here with just passing |
how to fix it |
@tofrookie @plrthink Test iOS With 0.29.0 , solve this by backgroundColor,
|
Setting backgroundColor to transparent is worked for me |
I'm on 0.29.1 and it's happening to me. Setting |
Same issue on 0.30.0 |
Same issue on 0.31.0-rc.0 while only passing in refreshing and onRefresh. Setting backgroundColor to transparent seems to have fixed the issue. |
It would be great if someone has time to investigate why this is happening as I don't have much time to look at this at the moment, seems like a really weird bug. We could always set the background color to transparent as a workaround but this doesn't seem ideal. There is also iOS 10 that bring first class support for UIRefreshControl in any UIScrollView so we might also want to try implementing RefreshControl with this technique and fallback on what we are doing now on iOS 9-. Hopefully that will fix most of the weird RefreshControl bugs and avoid having a bunch of hacky code to try to patch it. |
This bug has persisted for a very long time and is actually part of several apps for us now. So I submitted a PR in the hopes of assuaging our pain until @janicduplessis et. al. find a better way. |
This fixed a bug in react native that causes it to show in the top right, see facebook/react-native#7976
Summary: Refresh bug #7976 This bug has persisted for 3 versions of React Native. Currently everyone is having to do a silly fix, documented in the bug. I spent an hour trying to find the source of the bug. Failing to find the issue quickly, I've just decided to make this simple bugfix. According to janicduplessis #7976 we will likely be re-writing this control in iOS 10. Closes #9249 Differential Revision: D3817227 fbshipit-source-id: f98282aadeca3e85239836f589eda901d454f2ce
@Bhullnatik - you can close this, my PR was accepted, this will be fixed. |
I'm using 0.30 It works for me |
I have an issue with
RefreshControl
with React Native 0.27.x on iOS. TheRefreshControl
is creeping up on the top right side of my view until I use it the first time:The weird thing is that if I don't pass the
tintColor
prop, it works great.Here is my
RefreshControl
:cc @janicduplessis
The text was updated successfully, but these errors were encountered: