Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating build number with agvtool new-version -all {build number} doesn't work #879

Closed
peterprokop opened this issue Apr 16, 2015 · 5 comments
Closed

Updating build number with agvtool new-version -all {build number} doesn't work #879

peterprokop opened this issue Apr 16, 2015 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@peterprokop
Copy link

agvtool returns with:

Setting version of project {project} to: 
    {build number}.
Also setting CFBundleVersion key (assuming it exists)
Updating CFBundleVersion in Info.plist(s)...
$(SRCROOT)/iOS/Info.plist
Cannot find "$(SRCROOT)/iOS/Info.plist"
@oblador
Copy link
Contributor

oblador commented May 14, 2015

Had the same problem, solved it by making the path relative. Just remove $(SRCROOT)/ from the "Info.plist File" setting under Build Settings and it works just fine.

@christopherdro
Copy link
Contributor

@peterprokop
Did the solution from @oblador work for you?

@peterprokop
Copy link
Author

@christopherdro haven't tried it.
Used something like
/usr/libexec/PlistBuddy -c "Set CFBundleVersion $TRAVIS_BUILD_NUMBER" ./iOS/Info.plist
instead.

@brentvatne brentvatne mentioned this issue May 31, 2015
Closed
@brentvatne
Copy link
Collaborator

@oblador - that worked for me as well, submitted a PR to update the SampleApp accordingly

vjeux pushed a commit to vjeux/react-native that referenced this issue Jun 23, 2015
[SampleApp] Remove $(SRCROOT) from INFOPLIST_FILE to fix agvtool
6e568ee 
Summary:
Fixed facebook#879 - I'm not too familiar with this aspect of XCode so a sanity check here would be great @tadeuzagallo 😉
Closes facebook#1466
Github Author: Brent Vatne <brent.vatne@madriska.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
rozele referenced this issue in microsoft/react-native-windows May 25, 2016
[SampleApp] Remove $(SRCROOT) from INFOPLIST_FILE to fix agvtool
9c3e7a4 
Summary:
Fixed #879 - I'm not too familiar with this aspect of XCode so a sanity check here would be great @tadeuzagallo 😉
Closes facebook/react-native#1466
Github Author: Brent Vatne <brent.vatne@madriska.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@pencilcheck pencilcheck mentioned this issue Aug 2, 2017
Closed
@csemresari
Copy link

Thanks @oblador

@facebook facebook locked as resolved and limited conversation to collaborators May 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SampleApp] Remove $(SRCROOT) from INFOPLIST_FILE to fix agvtool
6 participants
@brentvatne @oblador @peterprokop @christopherdro @csemresari @react-native-bot