Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Haste dependency regex is over-eager #88

Closed
ide opened this issue Feb 21, 2015 · 2 comments
Closed

[Packager] Haste dependency regex is over-eager #88

ide opened this issue Feb 21, 2015 · 2 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Feb 21, 2015

If you have method named require on an object and call it with something that looks like a path, Haste parses it and puts it in the module map. Instead it should look for object-less require calls and maybe explicitly allow global.require and window.require.

Repro: X.require('./hello')

@ide ide added packager Good first issue Interested in collaborating? Take a stab at fixing one of these issues. labels May 29, 2015
@brentvatne brentvatne changed the title Haste dependency regex is over-eager [Packager] Haste dependency regex is over-eager May 31, 2015
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

harrykiselev pushed a commit to harrykiselev/react-native that referenced this issue Aug 5, 2015
Replacing global declarations
@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/packager-haste-dependency-regex-is-over-eager

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is super simple to use - just login with GitHub.

Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is heavily focused working on performance.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 23, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants