Tab Bar is broken when In-Call Status Bar is active

[soheil-zz]

[brentvatne]

@soheil - as discussed in IRC, built a library for you that fixes this: https://github.com/brentvatne/react-native-status-bar-size 😄

Could add this back into StatusBarManager perhaps when it has all of the kinks worked out, cc @tadeuzagallo @vjeux

[soheil-zz]

beautiful!

I also thought it'd be nice to be able to add an icon to NavigationIOS
instead of text:

so in RCTWrapperViewController.m I added an image if there is no text
passed (it'd be nice to add its own prop):

- (void)viewWillAppear:(BOOL)animated
...

    self.navigationItem.title = _navItem.title;

    if (!_navItem.title) {
      UIImage *image = [UIImage imageNamed:@"logo.png"];
      self.navigationItem.titleView = [[UIImageView alloc]
initWithImage:image];
    }

good job though!

[soheil-zz]

@brentvatne also this bug still occurs even with the StatusBar height known, I thought I could modify the height of the main view based on the StatusBar height but that didn't work. So I think we need another solution, but your StatusBar size is still a nice addition.

[brentvatne]

@soheil - you could add some negative margin when the status bar is larger to offset it

[soheil-zz]

I haven't tried - margin, but increasing the height only worked when status
bar got bigger but when it shrunk again decreasing the height oddly enough
made no effect.

On Wed, Apr 22, 2015 at 9:06 PM, Brent Vatne notifications@github.com
wrote:

@soheil https://github.com/soheil - you could add some negative margin
when the status bar is larger to offset it

—
Reply to this email directly or view it on GitHub
#972 (comment)
.