-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some common objc nits to the style guide #1006
Conversation
@nicklockwood @a2 @vjeux Want to add something else? (or remove something)
@tadeuzagallo - to JS, we could add something like:
For objc, do you have a preference on using |
It's difficult to know what level of detail to go into with something like this. We do have very specific style guidelines for Objective-C code, but they'd probably run to a dozen pages if we mentioned everything! The Besides that, may as well merge this as is and we can expand on it later as and when issues arise. |
Add some common objc nits to the style guide
…-fixes Cherry pick changes to fix building rn-tester app for android from main to 0.64-stable
Summary: This is a partial rollback of 07c0d539bdb3a248762d0a06fd3f622b278a7ecb. X-link: facebook/yoga#1006 Reviewed By: yungsters Differential Revision: D40032544 Pulled By: yungsters fbshipit-source-id: 9ef9b80672eced86a98cfae66c81710bd3ee6f9b
Summary: This is a partial rollback of 07c0d539bdb3a248762d0a06fd3f622b278a7ecb. X-link: facebook/yoga#1006 Reviewed By: yungsters Differential Revision: D40032544 Pulled By: yungsters fbshipit-source-id: 9ef9b80672eced86a98cfae66c81710bd3ee6f9b
@nicklockwood @a2 @vjeux Want to add something else? (or remove something)