Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextInput] returnKeyType, enablesReturnKeyAutomatically, more keyboardTypes #109

Closed
wants to merge 10 commits into from
Closed

[TextInput] returnKeyType, enablesReturnKeyAutomatically, more keyboardTypes #109

wants to merge 10 commits into from

Commits on Mar 26, 2015

  1. corrected typo in readme

    @roryqueue
    roryqueue committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    019d9cf View commit details
    Browse the repository at this point in the history

  2. Lint code - change double quotes to single in website/jsdocs. Add/rem… 

    …ove semicolons to keep code style
    @stephenlacy
    stephenlacy committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    5a4e780 View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @a2
    a2 committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    324f96b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #220 from stevelacy/lint 

    Lint code - change double quotes to single in website/jsdocs
    @a2
    a2 committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    821dcb5 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #219 from roryquinlan/master 

    Corrected typo in README
    @a2
    a2 committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    64010cc View commit details
    Browse the repository at this point in the history

  6. [README] Switch to public Travis badge

    @sophiebits
    sophiebits committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    6ff2d47 View commit details
    Browse the repository at this point in the history

  7. Bump react-native-cli version

    @sophiebits
    sophiebits committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    2665d77 View commit details
    Browse the repository at this point in the history

  8. Bump react-native-cli version actually

    @sophiebits
    sophiebits committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    5e7df58 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #223 from zpao/website-improvements 

    Website improvements
    @sophiebits
    sophiebits committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    b4da77a View commit details
    Browse the repository at this point in the history

  10. [TextInput] returnKeyType, enablesReturnKeyAutomatically, secureTextE… 

    …ntry more keyboardTypes

This diff completes adding support for the following UITextField properties:

returnKeyType: what the return key on the keyboard says
enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
secureTextEntry: obscure passwords
keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.
    @ide
    ide committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    326e0ee View commit details
    Browse the repository at this point in the history