Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS build warnings] Mark params __unused or #pragma unused #11797

Closed
wants to merge 3 commits into from
Closed

[iOS build warnings] Mark params __unused or #pragma unused #11797

wants to merge 3 commits into from

Conversation

robhogan
Copy link
Contributor

Motivation: reduce build noise that might worry new users or hide real problems.

This deals with four of the warnings currently in the iOS build. The __unused additions are standard and self-explanatory, following the style used elsewhere in RN. I've used #pragma unused to deal with parameters named by macros.

Tested by building and running the UIExplorer example app in XCode 8.2

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @donyu and @javache to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 10, 2017
@robhogan robhogan mentioned this pull request Jan 10, 2017
Closed
@ide
Copy link
Contributor

ide commented Jan 10, 2017

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@robhogan robhogan mentioned this pull request Jan 12, 2017
Closed
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2017
@rh389 @facebook-github-bot
Mark __unused completion block args
9e1e52f 
Summary:
Catching a couple more build warnings introduced by b50f550 since #11797.

Edit: and one more introduced by c68a708

Tested the build with UIExplorer.
Closes #11865

Differential Revision: D4415630

fbshipit-source-id: 1384d56770eea8665ede8bd9abe06cf34cd14b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robhogan @facebook-github-bot @ide