Pinned react (and co) to 16.0.0-alpha.4 #13121
Conversation
This will avoid breaking changes in subsequent alpha releases until the React team has created codemods and prepared the ReactNative codebase for this
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Why is CI trying to install |
|
@bvaughn Looks like the script for react-native init assumes that it all use the same version https://github.com/facebook/react-native/blob/master/local-cli/init/init.js#L91. |
|
Gah! Thanks for pointing that out @janicduplessis Updated that script as well. |
| if (!peerDependencies) { | ||
| console.error('Missing React peer dependency in React Native\'s package.json. Aborting.'); | ||
| return; | ||
| } else if (!devDependencies) { | ||
| console.error('Missing react-test-renderer dev dependency in React Native\'s package.json. Aborting.'); |
There was a problem hiding this comment.
Also maybe update the message to Missing dev dependencies ...
There was a problem hiding this comment.
Just copied above wording/formatting.
local-cli/init/init.js
Outdated
| @@ -72,6 +74,12 @@ function generateProject(destinationRoot, newProjectName, options) { | |||
| return; | |||
| } | |||
|
|
|||
| var reactTestRendererVersion = devDependencies['react-test-renderer']; | |||
| if (!reactVersion) { | |||
There was a problem hiding this comment.
This should be reactTestRendererVersion
There was a problem hiding this comment.
Blah. Yeah, sorry. Multi-tasking fail. Will fix. :)
bvaughn
force-pushed
the
pin-react-version
branch
from
ac37fa4 to
fef9278
Compare
|
@facebook-github-bot shipit |
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks for the review, @janicduplessis! |
|
Closing as these dependencies were recently updated to alpha6 in 6f9447e |
|
Shoud we still ship the change in |
|
@bvaughn ? |
|
Unsure. There was a transient problem with |
Some time ago (24a7665) the version of React specified in
package.jsonwas relaxed (presumably unintentionally). As a result, a recent backwards-incompatible release of React 16 alpha 5 caused some breakage in OSS.This PR pins the version of React to avoid breaking changes in subsequent alpha releases until the React team has created codemods and prepared the ReactNative codebase for this.
Since the change to
package.jsonwas made in February, this PR will need to go into the RC branch for the next ReactNative release in order to avoid breaking other apps in the OSS community.cc @mkonicek, @gaearon, @javache