fix missing lines in the ios picker #13342
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
The test plan seems incomplete. See https://medium.com/@martinkonicek/what-is-a-test-plan-8bfc840ec171 for more details. |
| @@ -19,7 +19,9 @@ @implementation RCTPickerManager | |||
|
|
|||
| - (UIView *)view | |||
| { | |||
| return [RCTPicker new]; | |||
| RCTPicker *picker = [RCTPicker new]; | |||
| [picker selectRow:0 inComponent:0 animated:YES]; | |||
There was a problem hiding this comment.
We definitely should not configure it here.
There was a problem hiding this comment.
whats different than before? we are not configuring anything here, im just setting some defaults so the lines appear.
There was a problem hiding this comment.
It just should be inside RCTPicker's init method, and View Managers should be as declarative as possible.
There was a problem hiding this comment.
The fix works fine within React/Views/RCTPickerManager.m but when I move it within RCTPicker's initWithFrame it doesn't work.
@shergin what am I doing wrong?
Thanks
|
maybe we should reopen this? #14442 is fixed with this pr. |
|
It looks like back in April I had some concerns with the test plan. After looking at it again, I do feel like the test plan is incomplete. |
|
i actually added a couple of test views in the |
|
Looks like I can't re-open the PR because the source branch was deleted. |
|
@pvinis Just put the hack inside |
|
i will try to make the bug happen again and make the branch again, plus the test views. @shergin unfortunatelly, still better than many other PRs.. |
|
Hi, Is there any update on this please I am trying to use picker and the lines disappear when I interact with it... |
|
No update at all - the pull request is closed and the source branch long gone. |
|
Thanks for the quick reply. But this is still an issue, any plan for fixing this in future, please? Also, let me know if I can help in any way... |
|
Sure, a good approach right now is to open a proper issue here in the repo with all the pertaining information. Even better - pick up on the work started here and submit your own PR. |
|
@adnanbabar I created a new PR for this issue, where I moved the code to the Hopefully that one will be merged. |
|
i hope so too. thanks @VSchlattinger. |
Summary: This PR is based on #13342 by pvinis and fixes #14442. As suggested in the discussion on the PR mentioned above, I moved the code from `React/Views/RCTPickerManager.m` to the `initWithFrame` function in `React/Views/RCTPicker.m` and verified that it still fixes the problem. Before the change in this PR the selection indicator lines are missing when the Picker is initially added to the View and only appear after changing to a different Tab and back. This happens both in the Simulator and my real device (iPhone 6S on iOS 11.3).  After the change, the indicator lines always appear. I did not notice any side effects of this change when playing around with the Picker in different configurations.  #13342 also fixes this issue but appears to be inactive. [IOS] [BUGFIX] [PickerIOS] - Fixed missing selection indicator lines Pull Request resolved: #18885 Differential Revision: D8945483 Pulled By: hramos fbshipit-source-id: 2b6c6f42559691530b062503feb24bc305f4a8af
fix missing lines in the ios picker. thanks to http://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10
Motivation (required)
as written in http://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10 there is a case where the picker is missing the highlight lines for the currently selected picker item. this fixes this case.
Test Plan (required)
no tests needed other than the highlight lines appear like in the stackoverflow link. and it works every time now, instead of sometimes lines missing.