[WebView] Support opening WebView links in external browser on iOS #1355
Conversation
facebook-github-bot
added
the
CLA Signed
| @@ -17,6 +17,7 @@ | |||
| @property (nonatomic, assign) UIEdgeInsets contentInset; | |||
| @property (nonatomic, assign) BOOL shouldInjectAJAXHandler; | |||
| @property (nonatomic, assign) BOOL automaticallyAdjustContentInsets; | |||
| @property (nonatomic, assign) BOOL openLinksInExternalBrowser; | |||
There was a problem hiding this comment.
BOOL openLinksInExternalBrowser;There was a problem hiding this comment.
@a2 What does that mean? Does that line have a mistake?
|
I tried using your PR and I am not able to get the links to open in external browser. I think this only works with but not with jquery on click listeners. |
|
@arunshan can you post some code that exposes the issue you're seeing? |
brentvatne
changed the title
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
|
@arunshan Yes, that is expected. The URL is never seen by the native webview itself if the click is handled completely by jQuery/JS. It would be an AJAX call and not a complete page reload. All, any other concerns with this PR? |
|
Any updates on this? |
|
@masonicboom updated the pull request. |
|
Closing since no activity on the PR. let's re-open if you wanna work on it again. |
* removed v0.5 * remove easily and swap obvious * remove just and swap easy * fixes for s thru end of alphabet * a thru e * f thru m * last of them except navigator * oops idk why i put that inline * last fixes for pop * pr resolve conflict * update ignore rule to include the word * add back 0.6
…nks (facebook#1355) Messenger Desktop is a multi-window application (chat, calling, settings, …) and we maintain the various windows with a windowNativeModule which allows JS interaction. When receiving deep-links from other apps we don’t want to necessary re-open the lastWindow open as the deep-link might contain information about a particular scenario (open login page, start a call). Hence, we need to disable this behavior app wide and use our windowNativeModule to forward the specific window related to the deep link. - This change has 0 effect on other apps - We could make this property an ivar, but then we need to manually register RCTLinkingManager.mm …. - We could append a special url property to deep-links, but I think that would make the ‘API’ harder to use`
No description provided.