Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigator] Support the ref prop on scene roots #1361

Closed
wants to merge 1 commit into from
Closed

[Navigator] Support the ref prop on scene roots #1361

wants to merge 1 commit into from

Commits on May 21, 2015

  1. [Navigator] Support the ref prop on scene roots 

    Navigator overrides the `ref` prop of scene components so that it can call `onItemRef` and do internal bookkeeping. With callback refs, we can additionally call the original value of the `ref` prop as long as it's a function (that is, string refs are not supported). Note that the `ref` prop is moved to `reactElement.ref` out of `reactElement.props.ref`, which is why this diff accesses `child.ref`.

This diff adds support for callback refs and warns helpfully if a string ref was provided. It should be completely backwards compatible since scenes couldn't have been relying on the `ref` prop before.
    @ide
    ide committed May 21, 2015
    Configuration menu
    Copy the full SHA
    c3afdd1 View commit details
    Browse the repository at this point in the history