Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packager] [0.45.0 backport] Fix broken default getProjectRoots #14413

Merged
merged 2 commits into from
Jun 9, 2017

Conversation

skevy
Copy link
Contributor

@skevy skevy commented Jun 9, 2017

This is a backport of #14412 to 0.45.0.

You'll notice the code is slightly different -- this is because Config.js has changed quite a bit between versions. The intent of the code is the same however.

See #14412 for a more detailed description.

Fixes #14246

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Jun 9, 2017
@skevy
Copy link
Contributor Author

skevy commented Jun 9, 2017

cc @grabbou (see convo in Slack), @hramos

@skevy skevy changed the title [packager] [0.45.0 hotfix] Fix broken default getProjectRoots [packager] [0.45.0 backport] Fix broken default getProjectRoots Jun 9, 2017
@hramos hramos merged commit f458ea4 into facebook:0.45-stable Jun 9, 2017
@grabbou
Copy link
Contributor

grabbou commented Jun 11, 2017

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants