Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init #14477

Closed
wants to merge 1 commit into from
Closed

fix init #14477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion local-cli/bundle/buildBundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

const log = require('../util/log').out('bundle');
const Server = require('metro-bundler/build/Server');
const Terminal = require('metro-bundler/build/lib/TerminalClass');
const Terminal = require('metro-bundler/build/lib/Terminal');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metro-bundler/build/lib/Terminal Required module not found

const TerminalReporter = require('metro-bundler/build/lib/TerminalReporter');
const TransformCaching = require('metro-bundler/build/lib/TransformCaching');

Expand Down
2 changes: 1 addition & 1 deletion local-cli/server/runServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
require('../../setupBabel')();
const InspectorProxy = require('./util/inspectorProxy.js');
const ReactPackager = require('metro-bundler');
const Terminal = require('metro-bundler/build/lib/TerminalClass');
const Terminal = require('metro-bundler/build/lib/Terminal');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metro-bundler/build/lib/Terminal Required module not found

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come Flow is complaining here? Doesn't that mean the project is still using the previous version of metro-bundler where it is still named TerminalClass? In which case we cannot switch it over just yet?


const attachHMRServer = require('./util/attachHMRServer');
const connect = require('connect');
Expand Down