Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update JS environment documentation for Babel #1449

Merged
merged 1 commit into from
May 31, 2015
Merged

[Docs] update JS environment documentation for Babel #1449

merged 1 commit into from
May 31, 2015

Conversation

jsierles
Copy link
Contributor

This PR needs review for accuracy of the links, and to add links for those which aren't linked. I couldn't find references to them in the babel documentation.

Fixes #274

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2015
@vjeux
Copy link
Contributor

vjeux commented May 29, 2015

Awesome, thanks!

You can find the correct list here:

whitelist: [
'es6.arrowFunctions',
'es6.blockScoping',
'es6.classes',
'es6.destructuring',
'es6.parameters.rest',
'es6.properties.computed',
'es6.properties.shorthand',
'es6.spread',
'es6.templateLiterals',
'es7.trailingFunctionCommas',
'es7.objectRestSpread',
'flow',
'react',
],

@jsierles
Copy link
Contributor Author

@vjeux Yes, that list is what's now referenced in the docs. Does that mean we should take out ES5 reserved words?

@vjeux
Copy link
Contributor

vjeux commented May 29, 2015

all the environments that we run on are ES5 so you can actually use reserved words. I would keep it there since people may not know about it

@brentvatne brentvatne changed the title update JS environment documentation for Babel [Docs] update JS environment documentation for Babel May 30, 2015
@brentvatne brentvatne merged commit f9b3f91 into facebook:master May 31, 2015
@amasad
Copy link
Contributor

amasad commented Jun 2, 2015

Can you please mention .babelrc to customize the transformers? see #1451

@jsierles jsierles deleted the babel-documentation branch June 3, 2015 13:07
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
)

* Adding GA tracking and user feedback input to docs pages.

* improving the path label

* Fix for netlify

Can confirm it's working in GA!
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that we're using Babel
5 participants