Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apple TV compile errors #14652

Closed
wants to merge 2 commits into from
Closed

Fix Apple TV compile errors #14652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54121f9
Fix Apple TV compile errors
douglowder Jun 21, 2017
27b2e36
Completely hide interface orientation methods for tvOS
douglowder Jun 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions React/Modules/RCTDeviceInfo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ - (void)interfaceOrientationDidChange

- (void)_interfaceOrientationDidChange
{
#if !TARGET_OS_TV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead hide the methods completely if !TARGET_OS_TV? So put them from line 96 to line 124.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

UIInterfaceOrientation nextOrientation = [RCTSharedApplication() statusBarOrientation];

// Update when we go from portrait to landscape, or landscape to portrait
Expand All @@ -121,6 +122,7 @@ - (void)_interfaceOrientationDidChange
}

_currentInterfaceOrientation = nextOrientation;
#endif
}


Expand Down
4 changes: 2 additions & 2 deletions React/Modules/RCTUIManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ RCT_EXTERN NSString *const RCTUIManagerRootViewKey;
- (void)rootViewForReactTag:(NSNumber *)reactTag withCompletion:(void (^)(UIView *view))completion;

/**
* Finds a view that is tagged with {@param nativeId} as its nativeID prop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to change these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is giving a "documentation error" when compiling and running the unit and integration tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile error image

* with the associated {@param rootTag} root tag view hierarchy. Returns the
* Finds a view that is tagged with nativeID as its nativeID prop
* with the associated rootTag root tag view hierarchy. Returns the
* view if found, nil otherwise.
*
* @param nativeID the id reference to native component relative to root view.
Expand Down