Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Configure Babel with .babelrc #1469

Closed
wants to merge 4 commits into from

Conversation

jtremback
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2015
@jtremback jtremback changed the title Configure Babel with .babelrc or package.json [Packager] Configure Babel with .babelrc or package.json May 31, 2015
@johanneslumpe
Copy link
Contributor

I don't think it's a good idea to have babel config in either .babel.rc or package.json. I'd just go for one to make it more explicit how to configure babel.

@jtremback
Copy link
Contributor Author

I'm just going on how Babel itself can be configured. I think there are advantages to either one. I prefer putting any configuration I can in package.json, because then I can just copy n paste to start a new project.

@johanneslumpe
Copy link
Contributor

@jtremback fair enough :)

@jtremback
Copy link
Contributor Author

Ooops. @johanneslumpe I was totally wrong. Am changing the PR to only look for .babelrc.

@jtremback jtremback changed the title [Packager] Configure Babel with .babelrc or package.json [Packager] Configure Babel with .babelrc May 31, 2015
@sebmck
Copy link
Contributor

sebmck commented Jun 1, 2015

The .babelrc lookup and merging behaviour in this PR is not consistent with how Babel does it. Babel can already resolve .babelrc files itself by just specifying an absolute filename to babel.transform. Ref #1451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants