add --port options to run-android, defaults to 8081 #15316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Generated by 🚫 dangerJS |
javache
reviewed
Aug 2, 2017
local-cli/runAndroid/runAndroid.js
Outdated
| @@ -56,10 +56,10 @@ function getAdbPath() { | |||
| } | |||
|
|
|||
| // Runs ADB reverse tcp:8081 tcp:8081 to allow loading the jsbundle from the packager | |||
| function tryRunAdbReverse(device) { | |||
| function tryRunAdbReverse(args, device) { | |||
There was a problem hiding this comment.
Instead of passing args through, can you pass packagerPort? That keeps the API saner.
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 5, 2018
Summary: The pull request adds the `--port` option to `run-ios` allowing a developer to build and launch a react-native app using a single command line like this: ``` react-native run-ios --port 8088 ``` It defaults to the current port 8081. This pull request fixes issue #9145 and issue #14113. This patch also extends `run-android` to properly test and launch the packager with the specified port, extending the work done in PR: ##15316 1. Create a new react-native app, or simply clone this branch and then update your version of react-native using `yarn add file:./path/to/this/fork/of/react-native` 2. run `react-native run-ios --port 8088` 3. watch the packager start on the desired port (8088 in this case) and watch your app in your simulator connect to the packager and launch the app. Closes #16172 Differential Revision: D6612534 Pulled By: shergin fbshipit-source-id: 50af449f5e4c32fb76ba95f4cb7bf179e35526d5
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: The pull request adds the `--port` option to `run-ios` allowing a developer to build and launch a react-native app using a single command line like this: ``` react-native run-ios --port 8088 ``` It defaults to the current port 8081. This pull request fixes issue facebook#9145 and issue facebook#14113. This patch also extends `run-android` to properly test and launch the packager with the specified port, extending the work done in PR: #facebook#15316 1. Create a new react-native app, or simply clone this branch and then update your version of react-native using `yarn add file:./path/to/this/fork/of/react-native` 2. run `react-native run-ios --port 8088` 3. watch the packager start on the desired port (8088 in this case) and watch your app in your simulator connect to the packager and launch the app. Closes facebook#16172 Differential Revision: D6612534 Pulled By: shergin fbshipit-source-id: 50af449f5e4c32fb76ba95f4cb7bf179e35526d5
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Closes facebook/react-native#15316 Differential Revision: D5582599 Pulled By: javache fbshipit-source-id: 575e0540965792a25e6cc572cff103da2c65a262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
npm linkto work correctly with my existing project, so this is a roundabout way of testing it.In this repo:
Run
react-native init fakeProject && cd fakeProjectRun
node '../local-cli/cli.js' run-android --help, list help and noticed port is present.Run
node '../local-cli/cli.js' run-android --port=8088, run command noticed adb is set correctly to 8088In android emulator open debug tools (command+M) goto
Debug server host & port for deviceand change it to
localhost:8088.Run
react-native start --port=8088, in a different shell.Reload.
Profit.
Suggestion welcome, if anyone knows a better way to test
runAndroidcommand.