[react-native] Add TouchableBounce to react-native exports #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@vjeux was TouchableBounce excluded because it's not part of the platform UI conventions? |
|
Hmmm, we made the explicit decision not to put TouchableBounce in the open source repo, must have slept back in by mistake. The problem with this component is that it looks very good when you are prototyping so people tend to use it a lot. But it is a very cheap component when used all over your app. Would be nice to put it in an npm repo so that people can use it but not as part of the stdlib |
|
@vjeux - I think it snuck in because of the 2048 example. Agreed, this would be nice as an external lib |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
Fix links for website
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can cause confusion to not have it here, as per #1542