Apple TV: TouchableOpacity and Button need hasTVPreferredFocus support

[douglowder]

Motivation

Give TouchableOpacity and Button the same TV focus support as is already present in TouchableHighlight.

Test plan

Manual testing on TV simulator and devices.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[douglowder]

@hramos could you please try importing this again?

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

Update, this failed internally with the following:

2 Flow errors detected!
=====Flow error #0====
/Libraries/Components/Button.js line 59 col 22-3: property `hasTVPreferredFocus`
Property not found in
react.js line 79 col 35-46: object type
=====Flow error #1====
/Libraries/Components/Button.js line 98 col 7-25: property `hasTVPreferredFocus`
Property not found in
/Libraries/Components/Button.js line 101 col 9-18: object type

[douglowder]

Thanks @hramos , I just submitted what I think is the fix. My environment is giving me a flow version mismatch and hundreds of flow errors, so it's hard to run those tests locally :)

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

Quick update: this is waiting on some internal snapshot tests we need to update, to account for the new prop. It's on my todo list.

[facebook-github-bot]

@dlowder-salesforce I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[hramos]

This is hopefully landing tonight. Sorry for the delay.