-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android,Ios]supporting button text resize #16351
Closed
jason9693
wants to merge
16
commits into
facebook:master
from
jason9693:gichang-yang-support-button-text-resize
Closed
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9ebe866
(modified)button props added "textSizeIOS" for setting button size in…
jason9693 e5f3b26
Update PULL_REQUEST_TEMPLATE.md
jason9693 6749869
Update PULL_REQUEST_TEMPLATE.md
jason9693 568e8d7
Update Button.js
jason9693 09b5752
support resize btn text in both platform.
jason9693 c116503
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 6da750b
Update PULL_REQUEST_TEMPLATE.md
jason9693 b9b940d
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 9c5eb4f
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 652ab55
Update PULL_REQUEST_TEMPLATE.md
jason9693 3c19cd8
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 ae8584e
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 3544f77
change name 'textSize' to 'fontSize'
jason9693 b8edc40
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 e6d4198
Merge branch 'master' into gichang-yang-support-button-text-resize
jason9693 c9d93b5
canceled conflict merge
jason9693 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd consider using the same terms for styling props here because you're mapping
textSize
tofontSize
. why not name thisfontSize
in the first place to prevent this internal remapping?also, your
textSize
propType def require a string, but here you convert it toint
- consider changing the proptype def tonumber
to remove the conversion? or make thatpropType
accept 2 types withoneOfTypes