[Android] CameraRoll support for Videos and Photos showed in same time #16429
Conversation
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
What's the status of this PR? |
|
I see that RN team only look for features that FB needs. Not what people need. So while they not need it there's no any status |
|
@kesha-antonov I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
We are already on 2018 and this problem has been there for more than a year, what are you waiting for Facebook? |
|
Facebook, what is going with this PR? Would love to be able to use this feature! |
|
Would like to see this feature asap |
|
@kesha-antonov looks like there are two action items that need your attention, test plan and release notes. @shergin I was referred to you as someone who might be able to help get this PR moving on the Facebook side. Would you please be able to help shepherd this or maybe point to someone who can help? |
|
Does this work? I need this feature, and I'll crowbar it into my build manually if I have to. |
|
@kesha-antonov I tried making the same changes to CameraRollManager as you've done, but it seems to have had no effect. Is there some additional step to making this work? |
react-native-bot
added
Android
Ran Commands
react-native-bot
added
Platform: Android
|
Any news regarding this PR? It's been ages. |
|
@bulats I'm using this package and works like a charm |
|
@FacuAcosta Thank you! Can confirm that it works. |
react-native-bot
added
the
Missing Test Plan
|
Hey there, I'm going through old PRs and noticed this PR has been flagged as lacking a test plan. @kesha-antonov do you plan on adding a test plan? |
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
Thank you so much for this contribution and sorry it took so long to get around to landing it. While there is
https://github.com/pentarex/react-native-gallery-manager which handles this use case nicely, I think the basic functionality in React Native should allow to pick both videos and photos.
|
@kesha-antonov merged commit 54534e7 into |
hramos
removed
Import Started
…k#16429) Summary: Right now you can choose to show Videos OR Photos. This PR allows to show both in the same time. [ANDROID][ENHANCEMENT] - Can show videos and photos from CameraRoll in the same time Pull Request resolved: facebook#16429 Differential Revision: D13839638 Pulled By: cpojer fbshipit-source-id: 5edc039552888c3ba8a40f39e262919fa7c00b39
Summary: Right now you can choose to show Videos OR Photos. This PR allows to show both in the same time. [ANDROID][ENHANCEMENT] - Can show videos and photos from CameraRoll in the same time Pull Request resolved: facebook/react-native#16429 Differential Revision: D13839638 Pulled By: cpojer fbshipit-source-id: 5edc039552888c3ba8a40f39e262919fa7c00b39
Summary: Right now you can choose to show Videos OR Photos. This PR allows to show both in the same time. [ANDROID][ENHANCEMENT] - Can show videos and photos from CameraRoll in the same time Pull Request resolved: facebook/react-native#16429 Differential Revision: D13839638 Pulled By: cpojer fbshipit-source-id: 5edc039552888c3ba8a40f39e262919fa7c00b39
Motivation
Right now you can choose to show Videos OR Photos.
This PR allows to show both in the same time.
Release Notes
[ANDROID][ENHANCEMENT] - Can show videos and photos from CameraRoll in the same time