【iOS】fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in iOS #16571
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
cc @dlowder-salesforce |
yacosdad
changed the title
|
@yygene I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@shergin sorry I didn't answer your earlier question.... moving tvOS-specific files to their own folder is a really good idea. I'll create an issue to track that. |
Summary: fix bugs please look at the code，u will know me. fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS [CATEGORY] [TYPE] [LOCATION] - MESSAGE [IOS] [BUGFIX] [React.podspec] - fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS Closes facebook#16571 Differential Revision: D6418919 Pulled By: shergin fbshipit-source-id: d05a1182314c9718447351c8d1a180ff61f21192
Summary: fix bugs please look at the code，u will know me. fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS [CATEGORY] [TYPE] [LOCATION] - MESSAGE [IOS] [BUGFIX] [React.podspec] - fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS Closes facebook#16571 Differential Revision: D6418919 Pulled By: shergin fbshipit-source-id: d05a1182314c9718447351c8d1a180ff61f21192
Motivation
fix bugs
Test Plan
please look at the code，u will know me.
Release Notes
fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS
[CATEGORY] [TYPE] [LOCATION] - MESSAGE
[IOS] [BUGFIX] [React.podspec] - fix tvOS file 'React/Base/RCTTVRemoteHandler*' included in subspec 'React/Core' iOS