Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image] Remove resizeMode from nativeOnlyProps to get rid of warning #1673

Closed
wants to merge 1 commit into from
Closed

[Image] Remove resizeMode from nativeOnlyProps to get rid of warning #1673

wants to merge 1 commit into from

Conversation

brentvatne
Copy link
Collaborator

@chirag04 pointed out in irc that he was getting warnings about using the resizeMode prop on Image. My understanding is that it should be used as a prop, and that using it in the style was slated to be deprecated.

screen_shot_2015-06-18_at_11 43 14_am_720

This pull request gets rid of the warning message above, but stops short of adding a warning when using resizeMode via style - I would like to continue and add that warning if you agree @vjeux

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 18, 2015
@chirag04
Copy link
Contributor

@brentvatne Anything on this? Now that react-native 0.6 is released i see this warning all over my app. :(

@brentvatne
Copy link
Collaborator Author

@chirag04 - this is fixed in 0.7.0-rc actually: 4750856

I'd wait until we merge in a fix for #1750 before using that version though

@brentvatne brentvatne closed this Jun 25, 2015
@chirag04
Copy link
Contributor

oh. Cool. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants